Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add office world #25

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Add office world #25

merged 3 commits into from
Nov 11, 2024

Conversation

IDavGal
Copy link
Collaborator

@IDavGal IDavGal commented Nov 1, 2024

🎉 New feature

Closes #8
Related to #24

Summary

Adds a world USD file for an office based on the work done for andino_gz. This PR serves as a kickoff for creating a more detailed world, adding assets and improving on top of the initial file.

image
image

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@IDavGal IDavGal changed the title Add HQ world Add office world Nov 1, 2024
Signed-off-by: IDavGal <[email protected]>
@IDavGal IDavGal force-pushed the igallesio/add_HQ_world branch from a9fdc88 to 923a2c3 Compare November 1, 2024 19:45
Signed-off-by: IDavGal <[email protected]>
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Is it possible to select this world when doing ros2 launch? I don't remember if we have an argument for doing so? If not can you add it so we can select using this world?

isaac_worlds/ekumen_hq.usda Outdated Show resolved Hide resolved
@francocipollone
Copy link
Collaborator

Let's try to scope this PR to have just the empty office and then we can work in a follow up PR for adding assets.

@francocipollone
Copy link
Collaborator

CC @BarceloChristian

@JCarosella
Copy link
Collaborator

@IDavGal Is there something I need to download to run this world? This is what I see when I load it, both in the container and locally:

image

@francocipollone
Copy link
Collaborator

@IDavGal Is there something I need to download to run this world? This is what I see when I load it, both in the container and locally:

Looks like the textures aren't copied here. We need to do so:

image

Signed-off-by: IDavGal <[email protected]>
@JCarosella
Copy link
Collaborator

Loaded correctly now!

image

@JCarosella JCarosella merged commit 4383fb1 into main Nov 11, 2024
1 check passed
@JCarosella JCarosella deleted the igallesio/add_HQ_world branch November 11, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add office world
3 participants