Add a note about not updated diagram #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franco Cipollone <[email protected]>
francocipollone
force-pushed
the
francocipollone/readme_pinout_patch
branch
from
4aaa4e0 to
bfc166b
Compare
francocipollone
changed the title
arilow
reviewed
May 14, 2024
andino_hardware/README.md
Outdated
| @@ -25,6 +25,9 @@ This package aims to provide the necessary information to the correct assembly o | |||
|
|
|||
| <img src="docs/arduino_motor_diagram.png" /> | |||
|
|
|||
| **Important❗ : As of a recent update, the A4 and A5 connections were moved to A2 and A3. This diagram will be updated soon. Refer to [andino_firmware/src/hw.h](../andino_firmware/src/hw.h) for pinout reference.** | |||
There was a problem hiding this comment.
Would it make sense to point recent update to the PR?
Maybe something like: "recent update (#215)"
There was a problem hiding this comment.
Done at 62f8792
There was a problem hiding this comment.
It can be added, just in case anyone is curious about what caused this change.
JesusSilvaUtrera
approved these changes
May 14, 2024
Signed-off-by: Franco Cipollone <[email protected]>
JesusSilvaUtrera
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #239
#181 Modifies connection for the analog input in the arduino. This PR add a comment stating that the diagram is not correct and that will be updated soon.