Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial stream interface and the Arduino implementation #220

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

jballoffet
Copy link
Member

@jballoffet jballoffet commented Feb 11, 2024

🎉 New feature

Related: #87

Summary

This PR adds a serial stream interface and the corresponding Arduino implementation.

More PRs will be sent to keep improving the code structure.

Note: this PR is expected to be submitted after #219.

Test it

Tested by ensuring code builds (changes on this PR are not used yet).

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jballoffet jballoffet changed the title Jballoffet/add serial stream interface Add serial stream interface and the Arduino implementation Feb 11, 2024
@jballoffet jballoffet force-pushed the jballoffet/add-serial-stream-interface branch from f55e743 to 98b56bb Compare February 11, 2024 19:37
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jballoffet jballoffet force-pushed the jballoffet/add-serial-stream-interface branch from 98b56bb to 6be02f8 Compare February 14, 2024 10:53
@jballoffet
Copy link
Member Author

Thanks @francocipollone!

@jballoffet jballoffet merged commit 68c7939 into humble Feb 14, 2024
4 checks passed
@jballoffet jballoffet deleted the jballoffet/add-serial-stream-interface branch February 14, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants