Modify Shell class API to allow dependency injection #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @francocipollone! |
Signed-off-by: Javier Balloffet <[email protected]>
jballoffet
force-pushed
the
jballoffet/inject-shell-dependencies
branch
from
ba9645a to
445069b
Compare
francocipollone
approved these changes
Feb 14, 2024
jballoffet
added a commit
that referenced
this pull request
Jun 17, 2024
* Improves andino_navigation package. (#224) Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Add basic Platform IO instructions (#229) Signed-off-by: Gary Servin <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Modify Shell class API to allow dependency injection (#221) Signed-off-by: Javier Balloffet <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Fixed wheel diameter in URDF (#93) Signed-off-by: JesusSilvaUtrera <[email protected]> * Added YAML file for default camera intrinsics (#169) Signed-off-by: JesusSilvaUtrera <[email protected]> * Adds references to o3de and isaac_sim simulations. (#232) Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Added README for andino_bringup (#233) Signed-off-by: JesusSilvaUtrera <[email protected]> * Added binaries installation docs (#234) Signed-off-by: JesusSilvaUtrera <[email protected]> * andino_apps package created and andino_navigation package updated (#235) * andino_apps package created and andino_navigation package updated Signed-off-by: JesusSilvaUtrera <[email protected]> * Minor changes from the PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Update andino_navigation README with changes from PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Add andino_apps package to ci.yaml Signed-off-by: JesusSilvaUtrera <[email protected]> * Fixed minor issues from the PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Added 'andino_apps' to the general README Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: JesusSilvaUtrera <[email protected]> * Minimal change to test launch file Signed-off-by: JesusSilvaUtrera <[email protected]> * Added webcam.yaml file and intrinsics are now publishing Signed-off-by: JesusSilvaUtrera <[email protected]> * Added raspicam.yaml with camera intrinsics and updated instructions in andino_hardware/README Signed-off-by: JesusSilvaUtrera <[email protected]> * Changed the 'camera_info_url' to be relative path Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> Signed-off-by: Gary Servin <[email protected]> Signed-off-by: Javier Balloffet <[email protected]> Co-authored-by: Franco Cipollone <[email protected]> Co-authored-by: Gary Servin <[email protected]> Co-authored-by: Javier Balloffet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Related: #87
Summary
This PR modifies the Shell class API in order to allow dependency injection (so as to allow adding unit tests on a future PR).
More PRs will be sent to keep improving the code structure.
Note: this PR is expected to be submitted after #220.
Test it
Tested by performing manual integration tests on the robot hardware.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.