Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Shell class init method #219

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

jballoffet
Copy link
Member

🎉 New feature

Related: #87

Summary

This PR modifies the Shell class init method to begin from init, for consistency.

Test it

Tested by running the following commands and ensuring code builds and tests build and pass:

pio run

and

pio test --environment=desktop

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Javier Balloffet <[email protected]>
@jballoffet jballoffet force-pushed the jballoffet/rename-shell-init-method branch from e378110 to 610f547 Compare February 14, 2024 10:40
@jballoffet
Copy link
Member Author

Thanks @francocipollone!

@jballoffet jballoffet merged commit d3b8315 into humble Feb 14, 2024
4 checks passed
@jballoffet jballoffet deleted the jballoffet/rename-shell-init-method branch February 14, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants