Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main function and app module #173

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

jballoffet
Copy link
Member

@jballoffet jballoffet commented Nov 18, 2023

🎉 New feature

Related: #87

Summary

This PR adds the main function and moves the application logic into a new module named app. The purpose of this change is to enable a future decoupling of the application code and the target MCU.

It is worth mentioning that the code keeps compiling both with Arduino IDE and with Visual Studio Code + PlatformIO.

More PRs will be sent to keep improving the code structure.

Test it

Tested by performing manual integration tests on the robot hardware.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jballoffet jballoffet changed the title Add main function Add main function and app module Nov 18, 2023
Signed-off-by: Javier Balloffet <[email protected]>
@jballoffet jballoffet force-pushed the jballoffet/add-main-function branch from f994265 to 8ce9a62 Compare November 19, 2023 17:56
@jballoffet jballoffet mentioned this pull request Nov 19, 2023
6 tasks
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jballoffet
Copy link
Member Author

Thanks!

@jballoffet jballoffet merged commit c4047e6 into humble Nov 23, 2023
2 checks passed
@jballoffet jballoffet deleted the jballoffet/add-main-function branch November 23, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants