Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add App class #175

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Add App class #175

merged 1 commit into from
Nov 23, 2023

Conversation

jballoffet
Copy link
Member

@jballoffet jballoffet commented Nov 19, 2023

🎉 New feature

Related: #87

Summary

This PR creates a new class named App that wraps the main application logic.

More PRs will be sent to keep improving the code structure.

Note: this PR is expected to be submitted after #173.

Test it

Tested by performing manual integration tests on the robot hardware.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jballoffet jballoffet force-pushed the jballoffet/add-main-class branch from 1db6993 to ecfc535 Compare November 19, 2023 19:04
@jballoffet jballoffet changed the title Add main class Add App class Nov 19, 2023
@jballoffet jballoffet mentioned this pull request Nov 19, 2023
6 tasks
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jballoffet
Copy link
Member Author

Thanks!

Signed-off-by: Javier Balloffet <[email protected]>
@jballoffet jballoffet force-pushed the jballoffet/add-main-class branch from ecfc535 to f1162ae Compare November 23, 2023 20:58
@jballoffet jballoffet merged commit 29f3c7a into humble Nov 23, 2023
3 checks passed
@jballoffet jballoffet deleted the jballoffet/add-main-class branch November 23, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants