-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #276 scan on iOS crash #278
base: master
Are you sure you want to change the base?
Conversation
@Atomico001 as @EddyVerbruggen does not seem to have time, could you merge this? |
I am a simple user, haven't permission to merge. I am waiting for this merge too :) |
https://github.com/nstudio/nativescript-plugins/tree/main/packages/nativescript-barcodescanner That will have this fix, we decided to go ahead and publish a version with the fix as it is needed in many projects that we work on, when and if Eddy comes back around to doing more OSS then we can merge things back together and have a consistent approach without fragmenting the plugin ecosystem. Sadly, at times, with all OSS that is the only option so for now we plan to try and help manage a version under our scope at @nstudio. If that doesn't work, anyone can take this branch/fork with the fix and |
Do we have an idea when this can be merged in and new version released? |
Will this be merged? ios crashes when I call scan on ios 16.1.2 and I urgently need a fix. I tried to checkout the forked code to publish it to my local repo but can't build because of those 2 errors:
@EddyVerbruggen could you merge this, if it fixes the ios crash. Thanks |
@maxximee use P.S. this has been addressed in the #278 (comment), so please take a time to read previous comments. |
init
the instance of the VolumeObserverClass.