-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random Crashes with ns7 core modules #61
Comments
The invocation that fails: The assertion is made in this code, either the one on L29 or L45 - we'd have to reproduce the case, while we have a debugger attached: @romandragan are there specific steps to reproduce - more importantly what views are involved? This seems to be a back-nav triggered crash when tearing down the UI. |
@rigor789, after some investigation it seems like it happens when navigating back from the view which has RadListView with horizontal orientation. I'm not saying it's due to horizontal orientation itself, but just saying to give more information. It's not all the time but pretty often and consistent behavior. |
@rigor789, confirming the issue is not reproduced if the target view has ScrollView instead of the RadListView. As you know it's pretty dirty workaround but at least it works for now... As we don't have any other options to render horizontal scrolling list. |
@rigor789, any update on this? |
Must say the app is now rarely, but still randomly crashes at random places, subjectively more often right after any modal window has been closed. Trace is the same:
cc @rigor789, @NathanaelA |
This comment was marked as abuse.
This comment was marked as abuse.
@NathanaelA, thanks, upgraded to 7.0.3 iOS runtime, will test on real device, cause still can't run the project on simulator due to this CLI issue: NativeScript/nativescript-cli#5411. |
@rigor789, @NathanaelA, the app is still crashing with:
or:
Generally, while interacting with ListView: scrolling, refreshing, showing/hiding etc. But could be in other places as well. Tested with:
|
I also experienced the same issue with nativescript-vue application using NativeScript 7 and
Tested with: CLI 7.0.11 |
This comment was marked as abuse.
This comment was marked as abuse.
@NathanaelA The
I'll test with project built with NS command to get more report log error if any. |
I am not able to share a sample project here, but while testing our real app, I just noticed the same crash as described here, so I just wanna share as much information as I can: My config:
Stack:
Further info: The crash occured on the Simulator with iOS 12.4 while navigating back to a page that contains a RadListView (nativescript-ui-listview 9.0.4). As other people here have already mentioned, this crash happened randomly. I navigated through many pages in our app forwards and backwards, many of them use a RadListView and it worked fine for a long time, so I guess it is not really related to the RadListView, maybe it will occur in a totally different situation next time. |
Hey, I had the same error that also seemed to point on RadListView as the issue. Some trial and error attempts later I figured out that it was
I was using this extensively, like a default setting for modals. But after refactoring so that this is used when it actually is a "modal-in-modal", everything is working like a charm without any crashes and "assertion failed" errors. |
Hi
Versions:
My package.json
Any help, even a small comment on this, is really appreciated. |
@mihernandez6 I'm getting the same thing. Crashes when the app calls configureTnsOAuth in nativescript-oauth2. You ever figure the issue out? |
Not yet, unfortunately. I was just playing around with the code, the problem seems to be something related to the delegate, but more actual tests are necessary. Inside the node_modules/@nativescript/core/application/index.ios.js I changed line 335 from this:
to this:
This isn't the right way to go, but at least I managed to run the app. I'll try to run it again after uninstall nativescript-oauth2 and see what happens. Thanks for your answer. Have a good one! Edit: NS team kindly suggested to change my NS core (iOS) to JSC, but it didn't work for me. |
Interesting... I'll give that a try. Thanks! Edit: Worked for me. OAuth2 now comes up and the application does not crash. |
Unfortunately, the above is not a fix, just creates more problems down the road. I think the nativescript-oauth2 project is failing to keep things up to date. |
I have noticed an increase in Firebase Crashlytics reports on this issue using the 8.1.0 iOS runtime as well:
|
I tracked the source of my issue to this: and switched to (thanks @bradmartin) |
Are there any updates on this? We are still noticing that with @nativescript/ios 8.2.3. Right now we have to stick with 8.0.0. |
I'm facing this problem on |
@felixkrautschuk @gustavotrott Are you still facing that issue with latest runtime and |
Now it is much better! I'll make further tests and let you know if I find problems. |
Hi seems to make a difference, I don't have the message "assertion failed" after coming back to home page on IOS. |
We're also experiencing pretty random but often crash from time to time on iOS devices with latest NS 7 core modules and the project built with Xcode 12:
Originally posted by @romandragan in NativeScript/NativeScript#8867 (comment)
The text was updated successfully, but these errors were encountered: