Migrate FATES parameter file switches to the namelist #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemieux
force-pushed
the
fates-switch-migration
branch
2 times, most recently
from
63076c8 to
7cbb40c
Compare
13 tasks
This commit facilitates moving this switch from the fates parameter file to the API. Note that the actual daylength factor value is always passed through the API. This just adds the switch to tell FATES to use it.
glemieux
force-pushed
the
fates-switch-migration
branch
from
2284172 to
1780cc7
Compare
This commit facilitates moving this switch from the FATES parameter file to the namelist
glemieux
force-pushed
the
fates-switch-migration
branch
2 times, most recently
from
204bb5f to
d825989
Compare
|
Per discussion at the CTSM SE meeting today, we came to a consensus that the FATES stomatal and leaf respiration models shouldn't be controlled by the existing namelist switches for CLM ( |
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
glemieux
force-pushed
the
fates-switch-migration
branch
from
d825989 to
47fd489
Compare
|
Note: This could be rebased to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses NGEET/fates#1295.
To be coordinated with NGEET/fates#1300.
Description of changes
List of switches to be moved:
fates_daylength_factor_switchfates_hydro_solverfates_leaf_photo_tempsens_modelfates_leaf_stomatal_assim_modelfates_leaf_stomatal_modelfates_maintresp_leaf_modelfates_mort_cstarvation_modelfates_rad_modelfates_regeneration_modelSpecific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? Should be B4B aside from namelist differences
Any User Interface Changes (namelist or namelist defaults changes)? Yes as this brings in new namelist options.
Does this create a need to change or add documentation? Did you do so?
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).