Fix issue #2793 #2806
Open
Fix issue #2793 #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevis-lmwg
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
@olyson I will approve preemptively, though I know that you're investigating a strange test-failure.
| @@ -579,7 +579,7 @@ subroutine InitHistory(this, bounds, is_simple_buildtemp, is_prog_buildtemp) | |||
| avgflag='A', long_name='urban heating flux', & | |||
| ptr_col=this%eflx_urban_heat_col, set_nourb=0._r8, c2l_scale_type='urbanf') | |||
| else | |||
| this%eflx_urban_ac_lun(begl:endl) = spval | |||
| this%eflx_building_lun(begl:endl) = spval | |||
|
I tried that test above with ctsm5.3.002 and it passed as expected. I then ran it 3 times with my branch and all passed. So must have been some kind of glitch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Set eflx_building_lun to spval properly
Specific notes
Contributors other than yourself, if any: @cathyxinchangli
CTSM Issues Fixed (include github issue #): #2793
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
Ran aux_clm.
Unexpected failures:
These failed because there was one variable not bfb, DPFCT_ROCK.
Unsure why that would be different.