Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Github workflow: "Pull Request Docs Check" #2499

Closed
wants to merge 32 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
662472a
Add GH workflow: "Pull Request Docs Check"
samsrabin Apr 29, 2024
0fa782d
Update docs-folder.
samsrabin Apr 29, 2024
003cd20
Add requirements.txt.
samsrabin Apr 29, 2024
a40ec60
Add pre-build-command and build-command.
samsrabin Apr 29, 2024
349e0a1
Add sphinx_rtd_theme to requirements.
samsrabin Apr 29, 2024
e5caf17
Make sphinx throw nitpicky errors instead of warning.
samsrabin Apr 29, 2024
ffe0947
Remove docs references to PTCLM.
samsrabin Apr 29, 2024
5008060
Remove ref to missing figure ndown_ctsm_diagram.svg.
samsrabin Apr 29, 2024
63a73ef
Make pr-docs-check run in escomp:base Docker container.
samsrabin Apr 29, 2024
4f362e0
Trying to get pr-docs-check to work in container.
samsrabin Apr 29, 2024
8b8657d
Set docs-folder to just "doc".
samsrabin Apr 29, 2024
7873afd
Add doc/requirements.txt, with just sphinx_rtd_theme.
samsrabin Apr 29, 2024
fa38d72
Add docutils>=0.19 to requirements.txt.
samsrabin Apr 29, 2024
9acd01b
make now fails on nitpicky warnings.
samsrabin Apr 29, 2024
da177a8
Change build-command from "make html" to "make".
samsrabin Apr 29, 2024
43dec3c
Revert "Change build-command from "make html" to "make"."
samsrabin Apr 29, 2024
9476fe7
Try running pr-docs-check on CentOS instead of Ubuntu.
samsrabin Apr 29, 2024
0cfefbb
Revert "Try running pr-docs-check on CentOS instead of Ubuntu."
samsrabin Apr 29, 2024
cf15c11
Resolve "invalid language code" warning.
samsrabin Apr 30, 2024
cf57f65
Update intersphinx_mapping to new format.
samsrabin Apr 30, 2024
499651c
pr-docs-check now runs raw; added new pr-docs-check-container.
samsrabin Apr 30, 2024
c0a5b29
Call "make fetch-images" from doc/.
samsrabin Apr 30, 2024
9e97967
Add pr-docs-check-container-raw.yml.
samsrabin Apr 30, 2024
b1c1aca
Remove "git lfs install" step rom pr-docs-check-container-raw.
samsrabin Apr 30, 2024
c58699b
Add troubleshooting output to pr-docs-check-container-raw.
samsrabin Apr 30, 2024
92e8cba
Add pr-docs-check-container-ssr action.
samsrabin Apr 30, 2024
7326b43
pr-docs-check-container-ssr: Skip "git lfs install" step.
samsrabin Apr 30, 2024
a5d155f
Revert pr-docs-check-container-ssr; add pr-docs-check-ssr.
samsrabin Apr 30, 2024
7e72de8
Delete all requirements.txt in doc/.
samsrabin Apr 30, 2024
af4abb2
pr-docs-check-ssr: Provide full path to build dir. Works!
samsrabin May 1, 2024
33f9e9d
Delete now-unneeded workflow experiments.
samsrabin May 1, 2024
b1c328a
Rename remaining workflow.
samsrabin May 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/pr-docs-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: "Pull Request Docs Check (SSR Fork)"
on:
- pull_request

jobs:
docs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: samsrabin/sphinx-action@use-escomp-base-container
with:
docs-folder: "doc/source"
pre-build-command: "git lfs install && git lfs pull --exclude='' --include=''"
build-command: "sphinx-build -W --keep-going -n -b html . /home/user/mounted_home/_build"
2 changes: 1 addition & 1 deletion doc/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#

# You can set these variables from the command line.
SPHINXOPTS =
SPHINXOPTS = -W --keep-going -n
SPHINXBUILD = sphinx-build
SPHINXPROJ = clmdoc
SOURCEDIR = source
Expand Down
4 changes: 2 additions & 2 deletions doc/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
#
# This is also used if you do content translation via gettext catalogs.
# Usually you set "language" from the command line for these cases.
language = None
language = "en"

# List of patterns, relative to source directory, that match files and
# directories to ignore when looking for source files.
Expand Down Expand Up @@ -178,7 +178,7 @@


# Example configuration for intersphinx: refer to the Python standard library.
intersphinx_mapping = {'https://docs.python.org/': None}
intersphinx_mapping = {'python': ('https://docs.python.org/', None)}

numfig = True
numfig_format = {'figure': 'Figure %s',
Expand Down
8 changes: 1 addition & 7 deletions doc/source/lilac/specific-atm-models/wrf-nesting.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,7 @@ A full description of all steps for a WRF-CTSM run are included here.
Therefore, we are not repeating the steps necessary for building WRF and
CTSM.

In this example we use a nested domain over the CONUS as shows below:

.. _Figure ctsm-ndown:

.. figure:: ndown_ctsm_diagram.svg

Flowchart for WRF-CTSM one-way nested simulations
In this example we use a nested domain over the continental United States.

Nested Simulations : Pre-processing (geogrid.exe)
-------------------------------------------------
Expand Down
1 change: 0 additions & 1 deletion doc/source/users_guide/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
adding-new-resolutions/index.rst
running-special-cases/index.rst
running-single-points/index.rst
running-PTCLM/index.rst
trouble-shooting/index.rst
testing/index.rst

Expand Down
3 changes: 0 additions & 3 deletions doc/source/users_guide/overview/getting-help.rst
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,6 @@ MOSART
PFT
Plant Function Type (PFT). A type of vegetation that CLM parameterizes.

PTCLM
PoinT CLM (PTCLM) a python script that operates on top of CLM for |version| to run single point simulations for CLM.

ROF
River runOff Model to route flow of surface water over land out to the ocean. |cesmrelease| has two components options for this
the new model MOSART and previous model RTM.
Expand Down
4 changes: 1 addition & 3 deletions doc/source/users_guide/overview/introduction.rst
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@ As a followup to the tools chapter, :ref:`adding-new-resolutions-section` tells

In :ref:`running-special-cases-section`, again for the expert user, we give details on how to do some particularly difficult special cases. For example, we give the protocol for spinning up the |version|-BGC and CLMCN models as well as CLM with dynamic vegetation active (CNDV). We give instructions to do a spinup case from a previous case with Coupler history output for atmospheric forcing. We also give instructions on running both the prognostic crop and irrigation models. Lastly we tell the user how to use the DATM model to send historical CO2 data to CLM.

:ref:`running-single-points` outlines how to do single-point or regional simulations using |version|. This is useful to either compare |version| simulations with point observational stations, such as tower sites (which might include your own atmospheric forcing), or to do quick simulations with CLM for example to test a new parameterization. There are several different ways given on how to perform single-point simulations which range from simple PTS_MODE to more complex where you create all your own datasets, tying into :ref:`using-clm-tools-section` and also :ref:`adding-new-resolutions-section` to add the files into the build-namelist XML database. The PTCLM python script to run single-point simulations was added back in for this release (but it has bugs that don't allow it to work out of the box). CLM4 in CESM1.0.5 has a fully working versions of PTCLM.

Need :ref:`running-PTCLM` blurb...
:ref:`running-single-points` outlines how to do single-point or regional simulations using |version|. This is useful to either compare |version| simulations with point observational stations, such as tower sites (which might include your own atmospheric forcing), or to do quick simulations with CLM for example to test a new parameterization. There are several different ways given on how to perform single-point simulations which range from simple PTS_MODE to more complex where you create all your own datasets, tying into :ref:`using-clm-tools-section` and also :ref:`adding-new-resolutions-section` to add the files into the build-namelist XML database.

:ref:`troubleshooting-index` gives some guidance on trouble-shooting problems when using |version|. It doesn't cover all possible problems with CLM, but gives you some guidelines for things that can be done for some common problems.

Expand Down
88 changes: 0 additions & 88 deletions doc/source/users_guide/running-PTCLM/adding-ptclm-site-data.rst

This file was deleted.

20 changes: 0 additions & 20 deletions doc/source/users_guide/running-PTCLM/index.rst

This file was deleted.

Loading
Loading