Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added padding to download dropdowns #525 #526

Closed
wants to merge 7 commits into from
Closed

feat: added padding to download dropdowns #525 #526

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
64e2659
added spacing at download buttons
hanzalahwaheed Oct 21, 2023
a15adbc
added padding to download dropdowns
hanzalahwaheed Oct 21, 2023
b34d739
Merge branch 'main' into download-button-spacing
hanzalahwaheed Oct 22, 2023
753bfdc
Merge remote-tracking branch 'upstream/main'
hanzalahwaheed Oct 22, 2023
c17365b
added padding to download dropdowns
hanzalahwaheed Oct 22, 2023
f18965e
Merge branch 'main' into download-button-spacing
hanzalahwaheed Oct 23, 2023
1f1dd25
added padding (fixed)
hanzalahwaheed Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 63 additions & 51 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1415,23 +1415,25 @@ <h2>Results</h2>
</button>
<div class="png-svg" data-dropdown="pic-text-dropdown1">
<!-- dropdown elements go here -->
<div class="dropdown-item" data-download="pic-text-PNG">
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download PNG
</div>
<div class="dropdown-item" data-download="pic-text-svg">
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download Svg
<div class="dropdown-item-svg-png">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your issue has nothing to do with the HTML, just CSS, you are just to style

<div class="dropdown-item" data-download="pic-text-PNG">
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download PNG
</div>
<div class="dropdown-item" data-download="pic-text-svg">
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download Svg
</div>
</div>
</div>
</div>
Expand Down Expand Up @@ -1489,23 +1491,31 @@ <h2>Results</h2>
</button>
<div class="png-svg" data-dropdown="gradient-text-dropdown1">
<!-- dropdown elements go here -->
<div class="dropdown-item" data-download="gradient-text-PNG">
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download PNG
</div>
<div class="dropdown-item" data-download="gradient-text-svg">
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download Svg
<div class="dropdown-item-svg-png">
<div
class="dropdown-item"
data-download="gradient-text-PNG"
>
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download PNG
</div>
<div
class="dropdown-item"
data-download="gradient-text-svg"
>
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download Svg
</div>
</div>
</div>
</div>
Expand Down Expand Up @@ -1821,23 +1831,25 @@ <h2>Results</h2>
</button>
<div class="png-svg" data-dropdown="text-shadow-dropdown1">
<!-- dropdown elements go here -->
<div class="dropdown-item" data-download="text-shadow-PNG">
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download PNG
</div>
<div class="dropdown-item" data-download="text-shadow-svg">
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download Svg
<div class="dropdown-item-svg-png">
<div class="dropdown-item" data-download="text-shadow-PNG">
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download PNG
</div>
<div class="dropdown-item" data-download="text-shadow-svg">
<iconify-icon
inline
icon="bxs:download"
style="color: white; margin-right: 5px"
width="20"
></iconify-icon>
Download Svg
</div>
</div>
</div>
</div>
Expand Down
6 changes: 5 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,8 +1027,8 @@ input[type='number']::-webkit-outer-spin-button {
.image-download .png-svg {
visibility: hidden;
position: absolute;
background-color: var(--primary-color);
color: var(--text-color);
background-color: var(--primary-color);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you changing the position, please revert back

transition: all 0.1s cubic-bezier(0.16, 1, 0.5, 1);
transform: translateY(0.5rem);
margin-top: 0.3rem;
Expand All @@ -1054,6 +1054,10 @@ input[type='number']::-webkit-outer-spin-button {
font-size: 12px;
}

.dropdown-item-svg-png {
padding: 5px 0px;
}

.dropdown-item:hover {
background-color: #0c49d2;
}
Expand Down
Loading