Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added padding to download dropdowns #525 #526

Closed
wants to merge 7 commits into from
Closed

feat: added padding to download dropdowns #525 #526

wants to merge 7 commits into from

Conversation

hanzalahwaheed
Copy link
Contributor

Fixes Issue

My PR closes #506

👨‍💻 Changes proposed(What did you do ?)

Add padding to the download dropdowns.

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

image

@vercel
Copy link

vercel bot commented Oct 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
code-magic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 11:13am

Dun-sin
Dun-sin requested changes Oct 22, 2023
View reviewed changes
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your changes spoils the code structure and will cause problems

index.html
width="20"
></iconify-icon>
Download Svg
<div class="dropdown-item-svg-png">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your issue has nothing to do with the HTML, just CSS, you are just to style

src/style.css
color: var(--text-color);
background-color: var(--primary-color);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you changing the position, please revert back

@hanzalahwaheed
Copy link
Contributor Author

hanzalahwaheed commented Oct 23, 2023 •
edited
Loading

@Dun-sin
I have made the required changes. Please check and tell if valid now.

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 23, 2023

@Dun-sin I have made the required changes. Please check and tell if valid now.

no, i don't want to see any change that has to do with html and no change that has to do with creating a new rule in css, it already has a style and a rule which is how it was made in the first place, locate it and add the padding, very simple

@hanzalahwaheed
Copy link
Contributor Author

@Dun-sin Done.

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 23, 2023

@Dun-sin Done.

There's no difference, there shouldn't be a new rule and I shouldn't see the html file in changes.

Sorry but if you don't get it right this time, the PR will be closed

@hanzalahwaheed
Copy link
Contributor Author

hanzalahwaheed commented Oct 23, 2023 •
edited
Loading

I don't think I get it. I'll make a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dun-sin Dun-sin Dun-sin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] add padding to the download dropdown
2 participants
@hanzalahwaheed @Dun-sin