-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pyproject.toml #1073
Use pyproject.toml #1073
Conversation
could we perhaps use something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Massive overhaul, thanks!
LGTM
pyproject.toml
Outdated
authors = [{ name = "Antoine Bertin", email = "[email protected]" }] | ||
maintainers = [{ name = "Antoine Bertin", email = "[email protected]" }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add yourself and other maintainers 🙏
I used it before but it has a huge problem: it needs all the .git folder to install. So you cannot install from the source tarball (which is the main install media for Arch Linux for instance). But maybe I can revert creating a |
I reverted creating |
ec775c7
to
c8e42ca
Compare
wait for #1082 |
cbad366
to
e35584d
Compare
good for a final review :) |
I added some rules for ruff: FA, BLE, RET, SIM, DTZ, FBT, ASYNC, TRY, full A and ANN2xx and ANN001 (the other are painful) One doubt that I have, should we add this? :
I prefer double-quote, but given that historically, all the strings in subliminal are single-quote, it will be a huge change... Done automatically by |
changing all quotes would be a mess in git history, imo we can keep the current style ( and enforce it with lints ) rather than change it |
added the |
Anything else or do you thing this can be merged @ptrcnull ? |
i think the only thing left is to add the current maintainers |
hey @ptrcnull , can you add yourself to the list of maintainer so we can merge this PR please? |
oh, i forgot i can just push to the branch; added |
Thanks, merged! |
In this PR:
pyproject.toml
setup.{cfg,py}
,{dev-,}requirements.txt
andpytest.ini
files.ruff
,mypy
andtypos
._version.py
file that holds only the__version__
variable. For later use ofbump-my-version
for instance.Needs to be merged after #1072
Partially solves #1071