Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair tests (without recomputing most of the cassettes) #1074

Merged
merged 1 commit into from
May 14, 2024

Conversation

getzze
Copy link
Collaborator

@getzze getzze commented May 9, 2024

Mostly changes to the tests files. The changes to the subliminal module are minimal.

@getzze
Copy link
Collaborator Author

getzze commented May 9, 2024

If we delete the old cassettes then more tests are failing, mainly due to Providers that stopped working (thesubdb, addic7ed, ...). These are for other PRs.

@getzze getzze force-pushed the repair-tests branch 3 times, most recently from 1e0bf46 to 1cf7c75 Compare May 14, 2024 11:14
fix core tests

xfail test that should be invalid

test correct default providers

failing tests

skip creating rar archives if rar is not installed

use gestdown instead of addic7ed

remove python2 stuff

reorganize tests folder
@getzze
Copy link
Collaborator Author

getzze commented May 14, 2024

Ok, this is good now (I had to remove some python2 code also).

After this PR, only the refiners and providers tests are failing.
@ptrcnull if you want to give a quick look, so we can merge this before #1073

@getzze getzze merged commit 7eb9811 into develop May 14, 2024
@getzze getzze deleted the repair-tests branch May 14, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants