Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate drive train functions within the drive train class #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Encapsulate drive train functions within the drive train class #26

wants to merge 2 commits into from

Conversation

rekhask
Copy link
Contributor

@rekhask rekhask commented Mar 15, 2022

No description provided.

@ParkerMeyers ParkerMeyers self-requested a review April 7, 2022 02:34
ParkerMeyers
ParkerMeyers approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@ParkerMeyers ParkerMeyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Merging is fine w/ me.

@ParkerMeyers ParkerMeyers self-requested a review April 7, 2022 02:39
ParkerMeyers
ParkerMeyers suggested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@ParkerMeyers ParkerMeyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-Reviewing due to failed build. I cannot see why the build is failing, but please check on this next meeting. Also, minor code suggestions.

src/main/java/bhs/devilbotz/subsystems/DriveTrain.java

}

public double getLeftMasterVoltage(){
return getLeftMaster().getMotorOutputVoltage();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motors are defined in the same file, can just call to leftMaster variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParkerMeyers ParkerMeyers ParkerMeyers requested changes

At least 1 approving review is required to merge this pull request.

Assignees

@loafdog loafdog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekhask @ParkerMeyers @loafdog