Setup shooter interface #8
Conversation
There was a problem hiding this comment.
I don't think these methods match the functionality we need as described in the Crescendo 2024 Driver Controls document for "Basic Dev/Debug".
- Shooter
- On - Right Trigger Pressed
- Off - Right Trigger Not Pressed
- Speed Control: ShuffleBoard
How would you implement these controls from the joystick right trigger press? How about the Shuffleboard GUI control for the speed?
|
Make sure to run spotless apply after your changes :) |
There was a problem hiding this comment.
Mostly the same comments as @BrownGenius , just make sure not to use arbitrary numbers and try to seperate the hardware and software. (We are not using sparks)
There was a problem hiding this comment.
The logic looks good. Please start working on implementing the actual shooter IO implementation in ShooterIOSparkMax.java. Looks like Crescendo 2024 Main Electrical Components has been updated with most of the necessary details.
The TOP/BOTTOM CAN ID is something that the software team decides on and can re-program the SparkMax FW as needed, so, for now, you can use any values. We need to make sure all CAN IDs are unique.
BTW, in general, we put robot specific information in a Constants.java file, but not to worry about that at this point. You can see ChargedUp2023 for an example of how we used the Constants.java file.
BrownGenius
requested review from
ParkerMeyers
and removed request for
ParkerMeyers
No description provided.