Fixes missing Weh emote on species #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know 80% of them are unused since no more diseases but base game species still have them so until then.
|
real question is how come lizards cant weh |
upstream issue |
|
weh! |
GreaseMonk
reviewed
Mar 24, 2024
nearlyNonexistent
referenced
this pull request
in nearlyNonexistent/Horizon-Station
Apr 14, 2024
* Add bunch of missing emote sounds I know 80% of them are unused since no more diseases but base game species still have them so until then. * Mothroach is no longer used * actually nah --------- Co-authored-by: Velcroboy <[email protected]>
VMSolidus
added a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
Apr 30, 2024
## Mirror of PR #992: [Fixes missing Weh emote on species](DeltaV-Station/Delta-v#992) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/9823203?v=4" width="16"/><a href="https://github.com/FluffiestFloof"> FluffiestFloof</a> at 2024-03-21 20:12:16 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/9823203?v=4" width="16"/><a href="https://github.com/FluffiestFloof"> FluffiestFloof</a> at 2024-03-28 18:27:42 UTC</aside> <sup> `c01d0cb4dda77000435ecace940728d4dc3495d6` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Adds weh emote sound on Felinid, Vulpkanin and Harpy. > Also add honk emote sound to Harpy, this is related to the honk reagent or whatever. > Also removes old no longer used Mothroach emotesounds from Nyano days since Mothroach was upstreamed a while ago. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > 🆑 > - fix: Felinids, Harpies and Vulpkanin should now Weh accordingly. > </details> Co-authored-by: Fluffiest Floofers <[email protected]> Co-authored-by: DEATHB4DEFEAT <[email protected]> Co-authored-by: VMSolidus <[email protected]>
NullWanderer
pushed a commit
that referenced
this pull request
May 7, 2024
## Mirror of PR #992: [Fixes missing Weh emote on species](#992) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/9823203?v=4" width="16"/><a href="https://github.com/FluffiestFloof"> FluffiestFloof</a> at 2024-03-21 20:12:16 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/9823203?v=4" width="16"/><a href="https://github.com/FluffiestFloof"> FluffiestFloof</a> at 2024-03-28 18:27:42 UTC</aside> <sup> `c01d0cb4dda77000435ecace940728d4dc3495d6` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Adds weh emote sound on Felinid, Vulpkanin and Harpy. > Also add honk emote sound to Harpy, this is related to the honk reagent or whatever. > Also removes old no longer used Mothroach emotesounds from Nyano days since Mothroach was upstreamed a while ago. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > 🆑 > - fix: Felinids, Harpies and Vulpkanin should now Weh accordingly. > </details> Co-authored-by: Fluffiest Floofers <[email protected]> Co-authored-by: DEATHB4DEFEAT <[email protected]> Co-authored-by: VMSolidus <[email protected]>
rbertoche
pushed a commit
to rbertoche/space-station-14
that referenced
this pull request
Jun 4, 2024
## Mirror of PR space-wizards#992: [Fixes missing Weh emote on species](DeltaV-Station/Delta-v#992) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/9823203?v=4" width="16"/><a href="https://github.com/FluffiestFloof"> FluffiestFloof</a> at 2024-03-21 20:12:16 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/9823203?v=4" width="16"/><a href="https://github.com/FluffiestFloof"> FluffiestFloof</a> at 2024-03-28 18:27:42 UTC</aside> <sup> `c01d0cb4dda77000435ecace940728d4dc3495d6` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Adds weh emote sound on Felinid, Vulpkanin and Harpy. > Also add honk emote sound to Harpy, this is related to the honk reagent or whatever. > Also removes old no longer used Mothroach emotesounds from Nyano days since Mothroach was upstreamed a while ago. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > 🆑 > - fix: Felinids, Harpies and Vulpkanin should now Weh accordingly. > </details> Co-authored-by: Fluffiest Floofers <[email protected]> Co-authored-by: DEATHB4DEFEAT <[email protected]> Co-authored-by: VMSolidus <[email protected]>
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 3, 2025
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> This PR fixes the issue where any corpses devoured by a space dragon dissapear upon the Dragon being gibbed or butchered. Cherry-picked from Wizden #28709 --- # TODO <!-- A list of everything you have to do before this PR is "complete" You probably won't have to complete everything before merging but it's good to leave future references --> n/a --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p> </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: zelezniciar - fix: Space dragons that get butchered or gibbed will now drop devoured corpses. Co-authored-by: Lyndomen <[email protected]> Co-authored-by: metalgearsloth <[email protected]>
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds weh emote sound on Felinid, Vulpkanin and Harpy.
Also add honk emote sound to Harpy, this is related to the honk reagent or whatever.
Also removes old no longer used Mothroach emotesounds from Nyano days since Mothroach was upstreamed a while ago.
Why / Balance
Technical details
Media
Breaking changes
Changelog
🆑