Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Commit

Permalink
Fixes missing Weh emote on species (#85)
Browse files Browse the repository at this point in the history
## Mirror of PR space-wizards#992: [Fixes missing Weh emote on
species](DeltaV-Station/Delta-v#992) from <img
src="https://avatars.githubusercontent.com/u/131613340?v=4"
alt="DeltaV-Station" width="22"/>
[DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v)

<aside>PR opened by <img
src="https://avatars.githubusercontent.com/u/9823203?v=4" width="16"/><a
href="https://github.com/FluffiestFloof"> FluffiestFloof</a> at
2024-03-21 20:12:16 UTC</aside>
<aside>PR merged by <img
src="https://avatars.githubusercontent.com/u/9823203?v=4" width="16"/><a
href="https://github.com/FluffiestFloof"> FluffiestFloof</a> at
2024-03-28 18:27:42 UTC</aside>
<sup>

`c01d0cb4dda77000435ecace940728d4dc3495d6`

</sup>

---

PR changed 0 files with 0 additions and 0 deletions.

The PR had the following labels:
- Changes: YML


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> Adds weh emote sound on Felinid, Vulpkanin and Harpy.
> Also add honk emote sound to Harpy, this is related to the honk
reagent or whatever.
> Also removes old no longer used Mothroach emotesounds from Nyano days
since Mothroach was upstreamed a while ago.
> 
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> 
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> 
> - [ ] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> 🆑
> - fix: Felinids, Harpies and Vulpkanin should now Weh accordingly.
> 


</details>

Co-authored-by: Fluffiest Floofers <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
  • Loading branch information
4 people authored and rbertoche committed Jun 4, 2024
1 parent 207e4ed commit ecb2318
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 16 deletions.
28 changes: 24 additions & 4 deletions Resources/Prototypes/DeltaV/Voice/speech_emote_sounds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@
collection: VulpkaninWhines
Howl:
collection: VulpkaninHowls
Honk:
collection: BikeHorn
Weh:
collection: Weh

- type: emoteSounds
id: MaleVulpkanin
Expand All @@ -72,12 +76,20 @@
collection: MaleSneezes
Cough:
collection: MaleCoughs
Yawn:
collection: MaleYawn
Snore:
collection: Snores
Honk:
collection: BikeHorn
Sigh:
collection: MaleSigh
Crying:
collection: MaleCry
Whistle:
collection: Whistles
Sigh:
collection: MaleSigh
Weh:
collection: Weh
Growl:
collection: VulpkaninGrowls
Snarl:
Expand All @@ -102,12 +114,20 @@
collection: FemaleSneezes
Cough:
collection: FemaleCoughs
Yawn:
collection: FemaleYawn
Snore:
collection: Snores
Honk:
collection: CluwneHorn
Sigh:
collection: FemaleSigh
Crying:
collection: FemaleCry
Whistle:
collection: Whistles
Sigh:
collection: FemaleSigh
Weh:
collection: Weh
Growl:
collection: VulpkaninGrowls
Snarl:
Expand Down
32 changes: 20 additions & 12 deletions Resources/Prototypes/Nyanotrasen/Voice/speech_emote_sounds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,20 @@
collection: MaleSneezes
Cough:
collection: MaleCoughs
Yawn:
collection: MaleYawn
Snore:
collection: Snores
Honk:
collection: BikeHorn
Sigh:
collection: MaleSigh
Crying:
collection: MaleCry
Whistle:
collection: Whistles
Weh:
collection: Weh
Hiss:
collection: FelinidHisses
Meow:
Expand All @@ -26,8 +36,6 @@
collection: FelinidGrowls
Purr:
collection: FelinidPurrs
Sigh:
collection: MaleSigh

- type: emoteSounds
id: FemaleFelinid
Expand All @@ -42,10 +50,20 @@
collection: FemaleSneezes
Cough:
collection: FemaleCoughs
Yawn:
collection: FemaleYawn
Snore:
collection: Snores
Honk:
collection: CluwneHorn
Sigh:
collection: FemaleSigh
Crying:
collection: FemaleCry
Whistle:
collection: Whistles
Weh:
collection: Weh
Hiss:
collection: FelinidHisses
Meow:
Expand All @@ -56,13 +74,3 @@
collection: FelinidGrowls
Purr:
collection: FelinidPurrs
Sigh:
collection: FemaleSigh

# mobs
- type: emoteSounds
id: Mothroach
sound:
path: /Audio/Voice/Moth/moth_squeak.ogg
params:
variation: 0.125

0 comments on commit ecb2318

Please sign in to comment.