Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Railgun #718

Merged
merged 45 commits into from
Apr 29, 2024
Merged

Railgun #718

merged 45 commits into from
Apr 29, 2024

Conversation

musicmanvr
Copy link
Contributor

@musicmanvr musicmanvr commented Jan 24, 2024

About the PR

This PR introduces a new weapon to the Syndicate arsenal for both traitors and nuclear operatives, the "Decimator" Railgun. It also includes a reverse engineered variant, admeme variant and laser variant for borgs when that system is ready for use, similar to the laser L6. Reverse engineering also unlocks the non-lethal bolts, the standard one must be reverse engineered.

The Decimator has a long charge-up, must be wielded, and shoots extremely slowly (0.30 firerate, 0.40 reverse engineered), but does 110 damage spread across three different damage types with normal rods, 15 piercing, 75 blunt, and 20 heat, along with 80 stamina damage.

The railgun rods cannot be crafted, and must be obtained through;

  • The purchase of extra ammo for 2 telecrystals.
  • Reverse engineering in the sec techfab,
  • Or through purchasing of the bundle itself, which comes with three.

Bolts are retrievable and do not break, but can bounce.

The addition of this PR would give syndicate operatives a terrifying new tool for taking down lone targets, but its steep price and requirement to wield alongside the slow fire-rate leaves the user vulnerable. It is also very loud, and the sound of the metal rod impacting makes a distinct noise.

Slimepeople, Oni, and Diona can survive a shot due to their innate damage resistance.

Stats:

  • 110 Base damage, 75 blunt, 15 Piercing, 20 Heat using Rebar Rods.
  • Also deals 80 stamina damage on hit.
  • Non-Lethal shots do 10 blunt and 100 stamina damage.
  • 25% Slowdown when holding, 15% for reverse engineered variant.
  • 0.3 Fire-rate, 0.4 for the reverse engineered variant.
  • Gigantic size.
  • Takes Rebar Rods, a new ammo type exclusive for the railgun.

Why / Balance

Syndicate weaponry has been pretty much the same for a while now, and I wanted to bring some variety to their pool with a new type of weapon entirely. The railgun is a powerful choice for teams, decimates unarmored targets, and leaves lightly armored targets near death, but its slow fire-rate and limited ammo pool encourage caution.

Technical details

The railgun is coded entirely in yml, which makes it simple to make changes to. New sound effects and yml files have been added to the DeltaV section of the prototypes menu, and the weapon has its own syndicate uplink fill as well, locale file included. The initial code is a bit messy, but I've ironed out any errors that I found in my initial runs of testing.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
railgun_showcase.mp4

Reverse engineering makes the railgun craftable from the security techfab.

COST:

Railgun:

  • 50 Steel
  • 20 Glass
  • 2.5 Gold
  • 5 Silver
  • 10 Plasma
  • 5 Uranium

Rebar Rod:

  • 3 Steel

Rebar Rod (Less Lethal):

  • Steel: 2.5
  • Plastic: 1

Breaking changes

Changelog

🆑 - Mike and Still-Icarus

  • add: Added the Decimator Railgun, a thunderous new weapon for both syndicate and nuclear operatives.

please work
removing old assets causing issues
both traitors and nukeops can buy this absurdly powerful cannon
shrimple as adding a new variant with two firemodes, overkill, and overkiller
fixing some trash
shoot cans and scare security
Slows you down when any variant is held as to make the weapon more balanced
adds a unique sprite for the laser variant of the railgun
i am dumb
@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Jan 24, 2024
Copy link
Contributor

github-actions bot commented Jan 24, 2024

RSI Diff Bot; head commit b2f2c3e merging into 6679835
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Guns/Ammunition/Cartridges/railrod.rsi

State Old New Status
base Added
icon Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Ammunition/Cartridges/railrod_nonlethal.rsi

State Old New Status
base Added
icon Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Projectiles/projectiles.rsi

State Old New Status
beam_heavy_green Added
impact_beam_heavy_green Added
muzzle_beam_heavy_green Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Railguns/railgun.rsi

State Old New Status
base Added
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Railguns/railgun_ert.rsi

State Old New Status
base Added
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Railguns/railgun_laser.rsi

State Old New Status
base Added
icon Added

Edit: diff updated after b2f2c3e

@musicmanvr musicmanvr marked this pull request as ready for review January 24, 2024 06:28
@musicmanvr musicmanvr requested a review from DebugOk as a code owner January 24, 2024 06:28
@leonardo-dabepis
Copy link
Contributor

For weapons in general, but especially a weapon this powerful, I would prefer if there were inhand sprites so that people can have a visual indicator that they're about to get decimated.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Mar 7, 2024
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Mar 8, 2024
@IamVelcroboy
Copy link
Member

This is our second oldest PR, where are we at with this?

@VMSolidus
Copy link
Contributor

This is our second oldest PR, where are we at with this?

Assuming all of me and Death's change requests were made, this is actually ready to merge. The test is a false negative related to mimic code RNG throwing off the map tests by complete random chance.

@IamVelcroboy
Copy link
Member

The test is a false negative related to mimic code RNG throwing off the map tests by complete random chance.

Yep, very familiar with that one. Haha

@IamVelcroboy
Copy link
Member

@DEATHB4DEFEAT does the change you requested still need to be addressed?

@deltanedas deltanedas merged commit c0de272 into DeltaV-Station:master Apr 29, 2024
13 checks passed
NullWanderer added a commit that referenced this pull request Apr 29, 2024
This reverts commit c0de272.
@NullWanderer NullWanderer mentioned this pull request Apr 29, 2024
deltanedas pushed a commit that referenced this pull request Apr 29, 2024
Revert "Railgun (#718)"

This reverts commit c0de272.
DannyFranklin

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants