Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI issue: Railgun PR causes CI failure (linter and build&test) #1153

Closed
pissdemon opened this issue Apr 29, 2024 · 4 comments
Closed

CI issue: Railgun PR causes CI failure (linter and build&test) #1153

pissdemon opened this issue Apr 29, 2024 · 4 comments
Labels
Priority: 5-Whenever Doesn't matter when this gets resolved

Comments

@pissdemon
Copy link
Contributor

pissdemon commented Apr 29, 2024

Build and test error: ----> Robust.Shared.Utility.DebugAssertException : Unknown tag: CannonRestrict
Linter error: Error: /Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Projectiles/railgun.yml(37,7) PrototypeID CannonRestrict for type Content.Shared.Tag.TagPrototype at Line: 37, Col: 7 not found

Caused by merge of #718

See:

Relevant yaml section:

@github-actions github-actions bot added the S: Untriaged This issue or PR needs labelling label Apr 29, 2024
@pissdemon
Copy link
Contributor Author

The CannonRestrict tag is not referenced anywhere else in the codebase so it should probably just be removed.

@pissdemon pissdemon changed the title CI issue: Railgun PR causes linter fail on master CI issue: Railgun PR causes YAML linter fail on master Apr 29, 2024
@pissdemon pissdemon changed the title CI issue: Railgun PR causes YAML linter fail on master CI issue: Railgun PR causes CI failure (linter and build&test) Apr 29, 2024
@pissdemon
Copy link
Contributor Author

pissdemon commented Apr 29, 2024

More specifically this is caused by space-wizards/space-station-14#26878 removing the CannonRestrict tag for restricting stuff from being shot from pneumatic cannons. That's a problem because there is no replacement.

On master if you have the bad tag in it causes exceptions (I think it might cause the entity to be deleted too, wasting TC?)

If you do remove the tag, instead of having to spend 21TC for the bundle with the Decimator, you can buy railgun ammo for 2TC and fire it from a pneumatic cannon which is very bad. I tested this with a master build and it works and one hit crits a naked Urist and two hit crits an officer. There is no replacement for the blacklist - they "fixed" the cannon blacklist issue by making it a 2x2 gridinv, but rods are 1x2 so two still fit in the cannon.

Also trying to pick a rod from a box causes:

[ERRO] system.actions: Failed to get action from action entity: box of rebar (2769/n2769, RailgunAmmoBag). Trace:    at System.Environment.get_StackTrace()
   at Content.Shared.Actions.SharedActionsSystem.TryGetActionData(Nullable`1 uid, BaseActionComponent& result, Boolean logError) in Content.Shared\Actions\SharedActionsSystem.cs:line 127
   at Content.Server.Store.Systems.StoreSystem.OnEntityRemoved(EntityUid uid, StoreRefundComponent component, EntRemovedFromContainerMessage args) in Content.Server\Store\Systems\StoreSystem.Refund.cs:line 18
...

@deltanedas
Copy link
Member

manually add blacklist with the rods tag

@therealDLondon therealDLondon added Priority: 5-Whenever Doesn't matter when this gets resolved and removed S: Untriaged This issue or PR needs labelling labels May 25, 2024
@MilonPL
Copy link
Member

MilonPL commented Sep 23, 2024

The railgun got reverted so I guess this is resolved.

@MilonPL MilonPL closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 5-Whenever Doesn't matter when this gets resolved
Projects
None yet
Development

No branches or pull requests

4 participants