Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Syndicate Paramedic, and Syndicate Medical Visor #707

Conversation

DangerRevolution
Copy link
Contributor

About the PR

Adds Syndicate Paramedic as a role + adds it to the uplink

Why / Balance

@evilexecutive requested, I assume a PR using this will follow soon?
This also adds a Syndicate Medical Visor; which will be functional when we merge space-wizards/space-station-14#21980

This should probably be added to the Syndicate Medic too but that's a misc change to this PR.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

@github-actions github-actions bot added the Changes: YML Changes any yml files label Jan 22, 2024
@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Jan 22, 2024
@DangerRevolution DangerRevolution marked this pull request as ready for review January 22, 2024 18:49
@DangerRevolution
Copy link
Contributor Author

The TC cost for the Paramedic is 10; which seems low however they are forcibly pacified and start with no gear of much value that isn't their gloves or their medical supplies. The "value" in this, is frankly, minimal at best, and I would argue the cost should be EVEN lower but I'm happy to hold it at 10.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 28, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 28, 2024
@JoeHammad1844 JoeHammad1844 mentioned this pull request Feb 10, 2024
1 task
@JoeHammad1844
Copy link
Contributor

#779

@DangerRevolution
Copy link
Contributor Author

#779

?

@JoeHammad1844
Copy link
Contributor

i made that pr like 3 weeks later with no knowledge of this lmao

@JoeHammad1844
Copy link
Contributor

JoeHammad1844 commented Feb 10, 2024

anyway

  1. I dont think the syndicate paramedic should have syndicate hud if regular tots can buy them, its just not needed for tators

  2. the description doesnt mention that they are a pacifist

  3. should be given to nukie medic

  4. should have a unique sprite

point 3 and 4 are solved with my PR

@DangerRevolution
Copy link
Contributor Author

anyway

  1. I dont think the syndicate paramedic should have syndicate hud if regular tots can buy them, its just not needed for tators
  2. the description doesnt mention that they are a pacifist
  3. should be given to nukie medic
  4. should have a unique sprite

point 3 and 4 are solved with my PR

Sure 👍

belt: ClothingBeltParamedicFilled
pocket1: HandheldGPSBasic
pocket2: HandheldCrewMonitor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is an extremely broken item to be available for the low low price of 10 tc

jumpsuit: UniformScrubsColorCybersun
back: ClothingBackpackDuffelSyndicateFilledMedical
shoes: ClothingShoesChameleonNoSlips
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason they start with no-slips instead of the regular shoes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so to clarify on this one. When I had originally requested that this PR be made, NoSlips were intended to be part of the outfit for, "To keep the paramedic from slipping in all the bloodstains". They aren't necessarily an essential part of the character, and really you can't slip in blood anyway, so they're here for a subtle bit of flavor. They could just as easily be replaced with ordinary black shoes that will also match the outfit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's essentially just yet another free item from the uplink

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make this an official request then. Let's swap the no-slips out for regular black shoes. They aren't essential to have anyway.

Resources/Locale/en-US/deltav/store/uplink-catalog.ftl Outdated Show resolved Hide resolved
Comment on lines +11 to +12
ghost-role-information-syndicate-paramedic-description = Someone needs medical assistance. You, the first person the syndicate could find, will help them.
ghost-role-information-syndicate-paramedic-rules = Normal syndicate antagonist rules apply. Work and assist whoever called you in, and don't harm them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be made clear you are supposed to be pacified.

@@ -0,0 +1,15 @@
- type: entity
parent: ClothingEyesHudMedical
id: ClothingEyesHudSyndicateMedical # This actually does nothing at the moment, but Wizden are close/have/are about to get the MedHud working again.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment here isn't required, and can be removed.

sprite: Clothing/Eyes/Hud/synd.rsi
- type: Clothing
sprite: Clothing/Eyes/Hud/synd.rsi
- type: ShowSyndicateIcons
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I have an issue here with the Hud having ShowSyndicateIcons. Namely that since it reveals certain antagonist roles to the wearer, it opens up the syndi paramed to abuse by powergamers. There's nothing really stopping security from mugging the poor guy for his HUD, and then use it to go play "Spot the Antags".

@@ -1,6 +1,9 @@
# Utility
uplink-reinforcement-radio-nukie-mouse-name = Mouse Operative Reinforcement Teleporter
uplink-reinforcement-radio-nukie-mouse-desc = Calls in a specially trained mouse operative to assist you.

uplink-reinforcement-radio-syndicate-paramedic-name = Syndicate Paramedic Reinforcement
uplink-reinforcement-radio-syndicate-paramedic-desc = Calls in a questionably trainled syndicate paramedic to assist you.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the description here can be improved. This is a good opportunity to add in loreful flavor text, rather than the usual jokes. Aside from the Typo, perhaps it can be rewritten to have more themes in common with the cybersun paramed outfit and its flavor texts.

@@ -18,3 +18,20 @@
sound: /Audio/Animals/mouse_squeak.ogg
- type: UseDelay
delay: 300

- type: entity
parent: ReinforcementRadioSyndicate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere in the parent hierarchy is a fart noise generator. Said noise generator should be overridden with something more serious by adding a matching component to this entity.

parent: ReinforcementRadioSyndicate
id: ReinforcementRadioSyndicateParamedic
name: syndicate paramedic reinforcement radio
description: Call in a syndicate paramedic instantly! Medical License not included.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get jokes out of the description, and keep it purely useful/loreful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1984

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jokes like that are a big part of the charm in 13/14, since anybody can contribute people put a little piece of themselves in their work, removing that just makes the game bland

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uplink description should be serious description should be funi


- type: entity
noSpawn: true
parent: MobHumanSyndicateAgent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the death squad names is probably fine, but this could also be improved with the addition of flavor text by adding a description:
Given that this entity isn't affiliated with Gorlex, it would probably be more appropriate to have it use the human name lists.

icon: { sprite: Objects/Devices/communication.rsi, state: old-radio }
cost:
Telecrystal: 10 # This Paramedic has taken an Oath to do no harm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual TC cost should probably be discussed a little more. Since the paramed is also bundled with a few syndicate items, he has a somewhat inflated inherent value. For example the cost of his NoSlips and Surgical Bundle should probably be added to this baseline cost.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also just buy two combat medkits for that price which is more conveniant and i think has more healing, the advantage with the paramedic should be that, well, its another pair of hands.

i think it should cost the same as the regular reinforcement, the inability to do harm is offset by their starting gear

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also just buy two combat medkits for that price which is more conveniant and i think has more healing, the advantage with the paramedic should be that, well, its another pair of hands.

i think it should cost the same as the regular reinforcement, the inability to do harm is offset by their starting gear

I think the starting reinforcement cost is really dumb

jumpsuit: UniformScrubsColorCybersun
back: ClothingBackpackDuffelSyndicateFilledMedical
shoes: ClothingShoesChameleonNoSlips
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make this an official request then. Let's swap the no-slips out for regular black shoes. They aren't essential to have anyway.

@DangerRevolution DangerRevolution marked this pull request as draft February 10, 2024 22:18
@JoeHammad1844
Copy link
Contributor

have them spawn with red shoes because red is EVIL!!

@DangerRevolution DangerRevolution deleted the syndicate-paramedic branch March 31, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants