Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add glimmer/psionic artifact stuff #1785

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Sep 10, 2024

About the PR

1 trigger, "Psionic disturbance":

  • someone using a psionic power nearby, same as metapsionic popup

4 effects, "Noospheric shift":

  • raise glimmer by 30 up to 450
  • raise glimmer by 70 up to 700
  • lower glimmer by 50 down to 400
  • make everyone in a 5 meter radius psionic

Why / Balance

glimmer and psionics have no real impact on research (turn off prober roundstart and you are basically safe forever, psionics have no integration with research at all)

this makes psionic powers a trigger so having people be psionic is a necessary evil for epi, and an effect that can sometimes make them psionic
raising glimmer can be used by traitors, if you can get it in a loop and farm it you can permanently keep glimmer at a moderate or high level :trollface:
lowering glimmer to a safe level can be used in an emergency

Technical details

  • optimised and refactored metapsionic logic so it only looks up metapsionic power instead of any entity in 10 meters
  • fixed only 1 person with metapsionic pulse being notified of a power being used, now everyone with it gets notified

Media

a lower glimmer node
03:11:46

psionic effect is real
03:16:10

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
🆑

  • add: Artifacts can now interact with the noosphere in several ways.

@deltanedas deltanedas requested a review from a team September 10, 2024 20:49
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files labels Sep 10, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML / FTL looks fine - if I can get someone's eyes on the C# to also say it looks fine that would be nice. @MilonPL @MilonPL @MilonPL

@deltanedas
Copy link
Member Author

YAML / FTL looks fine

:trollface:

Copy link
Contributor

@TadJohnson00 TadJohnson00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was I requested for review :imcry:
this all looks fine from yaml but need someone to check over C# before merge

@Samsterious
Copy link
Contributor

why was I requested for review :imcry:

Because you're leading the charge on psionics and I wanted your opinion, nerd :blunt:

@TadJohnson00
Copy link
Contributor

why was I requested for review :imcry:

Because you're leading the charge on psionics and I wanted your opinion, nerd :blunt:

just throw a book or a blunt object at me over discord nerd!!!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't catch that, reapproving though.

@deltanedas deltanedas merged commit 845d584 into DeltaV-Station:master Sep 12, 2024
11 checks passed
@deltanedas deltanedas deleted the glimmer-ops branch September 12, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants