-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tourist #1037
Tourist #1037
Conversation
This reverts commit f691377.
also ready once i make something interesting for their job & PDA locale |
Mark it as draft if it isn't ready. Also this is literally Passenger but with a different name? |
Yes |
to be honest i think this is going to be the first time i ever say bloat. all of these extra passenger roles could just be handled through the loadout system. there was talk of letting people select different job titles too alongside that, i think that would be... better than adding a bunch of roles that do practically nothing not to mention theres a really cool upstream pr for tourist as a minor "antag" which i think would be more interesting |
when loadout comes I'd be happy to merge these together into a Passenger megaclass along with the rest of the role bloat |
i think its a little silly to, in the meantime, add a bunch of roles that you KNOW are going to be removed, along with all the map edits itll require |
I don't know they're going to be removed as I have no assurances that Loadouts will support manifest edits following ID changes; I don't even know if loadouts will be merged / finished and I don't know if we'll accept the amount of edits I want for loadouts.
This is optional for mappers; up to them if they want to have Tourists or not. I personally would want it for my map as a Passenger replacement, but other maps can not include them and it creates no extra burden for them. |
If this is for a specific map, I'd say add it along with the map PR. I didn't look too close at it but the tourist midround PR from upstream seems like it would be better than this. Or, when loadouts, I guess. |
# Description So you can actually muzzle a felinid to stop them from meowing. Or a vulp from barking. Or a human from screaming. You get the point. This muzzle part of this PR is a bit hardcode-y, but it's because the muzzle simply adds a replacement accent to the entity instead of using its own system to block speech. <details><summary><h1>Media</h1></summary> <p> https://github.com/user-attachments/assets/0e5e4986-d2a0-471a-a119-579741265178 </p> </details> # Changelog :cl: - add: Sleeping and muzzled entities can no longer use vocal emotes (scream, meow, etc).
About the PR
Title.
Why / Balance
A) I want this for a map in the works.
B) Useful for other maps
C) Again, provides a reason for someone to be on station more so than a miscellaneous "make your own, you're just someone on here" and Tourist is more of an
external
role; allowing for concepts such as "I don't know every single job on this station, what do you do here man dressed in yellows" which we normally can't RP. + can be given tours, the potential is higher and the requirement for someone to RP this; and for someone to understand IC that "hey, this person doesn't know the station inside and out" is more interesting.Media
Changelog
no changelog