Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barber #1036

Closed
wants to merge 13 commits into from
Closed

Barber #1036

wants to merge 13 commits into from

Conversation

DangerRevolution
Copy link
Contributor

@DangerRevolution DangerRevolution commented Mar 30, 2024

About the PR

Title.

Why / Balance

Allows for Barbershop RP; which already exists, but in limited quantities as most people don't know it's mapped (because it's not mapped on every station, hence this is a station-specific role). and actually leverages the existence of the Barber system for something interesting. Again, use of this role is a mappers choice.

Media

  • PR does not require an ingame showcase

Changelog

🆑

  • add: Barbers are now licensed to operate on station.

@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Mar 30, 2024
@DangerRevolution
Copy link
Contributor Author

Still need to think of something interesting for their job description & PDA but PR otherwise finito.

@DangerRevolution DangerRevolution marked this pull request as draft March 31, 2024 07:35
@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an rsi label Mar 31, 2024
Copy link
Contributor

github-actions bot commented Mar 31, 2024

RSI Diff Bot; head commit 989275b merging into 6d701a7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Interface/Misc/job_icons.rsi

State Old New Status
Barber Added

Resources/Textures/DeltaV/Objects/Misc/id_cards.rsi

State Old New Status
idbarber Added

Edit: diff updated after 989275b

@DangerRevolution DangerRevolution marked this pull request as ready for review March 31, 2024 08:17
@IamVelcroboy
Copy link
Member

I personally like this. I think they should have a unique uniform if we add them though.

I will add though, that this was initially voted down when I first suggested it. So, I'll let other maintainers/heads weigh in too.

@DangerRevolution DangerRevolution marked this pull request as draft April 17, 2024 20:40
@DangerRevolution
Copy link
Contributor Author

this and #1037 are covered in upcoming loadouts, when someone fixes the ID system :))

@DangerRevolution DangerRevolution deleted the Barber branch April 20, 2024 10:20
@Timemaster99
Copy link
Contributor

this and #1037 are covered in upcoming loadouts, when someone fixes the ID system :))

#1218 allows for a custom ID inside of the PDA loadout slot to change the job name. You could reuse this system to make these roles now

LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description
This reverts most code changes done by
Simple-Station/Einstein-Engines#939 and
re-implements them in a better way:
- Players can now toggle under-furniture crawling with a keybind
(shift-R by default)
- Crawling that way is 50% slower for obvious balancing reasons
- The respective cvar for it is now true by default and prevents players
from beginning the "crawl under furniture" thing

Also cleaned up a few methods I was seriously pissed off by. There is
still a lot to clean up and fix, but I will leave it for a dedicated PR
in the future.

# Why (balancing)
Let me lie on the bed instead of under it!!!!!!!

<details><summary><h1>Media</h1></summary>
<p>


https://github.com/user-attachments/assets/5f04c82a-b88b-4005-8052-a1a6f011bcc9

</p>
</details>

# Changelog
:cl:
- add: You can now toggle crawling under furniture! The default keybind
is Shift-R, you can change it in settings.
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants