Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix if styleSheetId cannot be retrieved #8

Open
wants to merge 8 commits into
base: r9_develop
Choose a base branch
from
Open

fix if styleSheetId cannot be retrieved #8

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9bc3835
Merge pull request #4 from DatabayAG/r9_develop
mBeym Feb 22, 2024
5c818d2
r9_develop => r9_release (#5)
mBeym May 7, 2024
a1f1005
r9_develop => r9_release (#7)
mBeym Nov 14, 2024
dc7cece
fix if styleSheetId cannot be retrieved
ingoj Dec 2, 2024
5fb7359
Update ilias_en.lang missing/wrong langvar
ingoj Dec 3, 2024
4bec9b1
Update ilias_en.lang typo
ingoj Dec 3, 2024
c2f8a59
Update ilias_de.lang missing/wrong langvar
ingoj Dec 3, 2024
5f706ff
Update ilias_en.lang cleanup empty line
ingoj Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion classes/Content/PageEditor/class.xudfPageObjectGUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,13 @@ public function __construct(xudfContentGUI $parent_gui)
$tpl->parseCurrentBlock();

$tpl->setCurrentBlock("ContentStyle");
$style_id = $parent_gui->getObject()->getStyleSheetId();
if ($style_id == null) {
$style_id = 0;
}
Comment on lines +55 to +58
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, $parent_gui->getObject()->getStyleSheetId() already defaults to 0 and never null.

See: ilObjStyleSheet::lookupObjectStyle

$tpl->setVariable(
"LOCATION_CONTENT_STYLESHEET",
ilObjStyleSheet::getContentStylePath($parent_gui->getObject()->getStyleSheetId())
ilObjStyleSheet::getContentStylePath($style_id))
);
$tpl->parseCurrentBlock();
}
Expand Down