fix if styleSheetId cannot be retrieved #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r9_develop => r9_release
* Fix missing cast * Fix wrong parameter type used * Fix no data found for table error * Fix undefined property access * Fix undefined array access * Fix mail send error causing hard crash
* Fix missing cast * Fix missing cast * Fix wrong parameter type used * Fix missing cast * Fix missing cast * Fix missing cast * Fix no data found * Fix undefined property access * Fix undefined array access * Fix mail error causing crash * Fix issue with REQUEST_URI modification in libs (#6)
mBeym
requested changes
Dec 6, 2024
Comment on lines
+55
to
+58
| $style_id = $parent_gui->getObject()->getStyleSheetId(); | ||
| if ($style_id == null) { | ||
| $style_id = 0; | ||
| } |
There was a problem hiding this comment.
From what I can see, $parent_gui->getObject()->getStyleSheetId() already defaults to 0 and never null.
See: ilObjStyleSheet::lookupObjectStyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we sometimes encountered an error if the stylesheetId could not be retrieved and was a null. Just a little fix to prevent this