Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parametric: enable python otel env telemetry tests #3497

Merged
merged 10 commits into from
Nov 26, 2024
Merged

parametric: enable python otel env telemetry tests #3497

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dc436f6
parametric: enable python otel env telemetry tests
mabdinur Nov 19, 2024
f89b8ed
Merge branch 'main' into munir/enable-python-otel-tests
mabdinur Nov 20, 2024
717ee2b
fix node tests
mabdinur Nov 20, 2024
ddbbf2e
add skip for nodejs
mabdinur Nov 20, 2024
a0eeac7
skip nodejs test and fix namespace assertion
mabdinur Nov 22, 2024
074f114
remove comment
mabdinur Nov 22, 2024
af8989f
lint
mabdinur Nov 22, 2024
aa4def0
fix nodejs
mabdinur Nov 22, 2024
a81d5ed
fix reason
mabdinur Nov 22, 2024
b95febe
add skip for v2.17.0
mabdinur Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 75 additions & 52 deletions tests/parametric/test_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def test_library_settings(self, library_env, test_agent, test_library):
@missing_feature(context.library == "ruby", reason="Not implemented")
@missing_feature(context.library == "php", reason="Not implemented")
@missing_feature(context.library == "cpp", reason="Not implemented")
@missing_feature(context.library == "python", reason="Not implemented")
@missing_feature(context.library < "python@2.18.0.dev", reason="Not implemented")
@pytest.mark.parametrize(
"library_env",
[
Expand Down Expand Up @@ -308,41 +308,52 @@ def test_telemetry_otel_env_hiding(self, library_env, test_agent, test_library):
assert event["request_type"] == "generate-metrics"

metrics = payload["series"]

# python tracer stores all telemetry metrics under the tracer namespace, it seems like nodejs and golang do not
mabdinur marked this conversation as resolved.
Show resolved Hide resolved
assert payload["namespace"] == "tracers"

otelHiding = [s for s in metrics if s["metric"] == "otel.env.hiding"]
otelInvalid = [s for s in metrics if s["metric"] == "otel.env.invalid"]

assert len(otelHiding) == 9
assert len(otelInvalid) == 0

expected_tags = [
["config_datadog:dd_trace_log_level", "config_opentelemetry:otel_log_level"]
if context.library == "nodejs"
else ["config_datadog:dd_log_level", "config_opentelemetry:otel_log_level"],
["config_datadog:dd_trace_propagation_style", "config_opentelemetry:otel_propagators"],
["config_datadog:dd_service", "config_opentelemetry:otel_service_name"],
["config_datadog:dd_trace_sample_rate", "config_opentelemetry:otel_traces_sampler"],
["config_datadog:dd_trace_sample_rate", "config_opentelemetry:otel_traces_sampler_arg"],
["config_datadog:dd_trace_enabled", "config_opentelemetry:otel_traces_exporter"],
["config_datadog:dd_runtime_metrics_enabled", "config_opentelemetry:otel_metrics_exporter"],
["config_datadog:dd_tags", "config_opentelemetry:otel_resource_attributes"],
["config_datadog:dd_trace_otel_enabled", "config_opentelemetry:otel_sdk_disabled"],
]

for expected in expected_tags:
assert any(all(tag in metric["tags"] for tag in expected) for metric in otelHiding)

for metric in otelHiding:
assert metric["points"][0][1] == 1
assert not [s for s in metrics if s["metric"] == "otel.env.invalid"]

if context.library == "nodejs":
ddlog_config = "dd_trace_log_level"
elif context.library == "python":
ddlog_config = "dd_trace_debug"
else:
ddlog_config = "dd_log_level"

if context.library == "python":
otelsampler_config = "otel_traces_sampler"
else:
otelsampler_config = "otel_traces_sampler_arg"

for dd_config, otel_config in [
["dd_trace_propagation_style", "otel_propagators"],
["dd_service", "otel_service_name"],
["dd_trace_sample_rate", "otel_traces_sampler"],
["dd_trace_enabled", "otel_traces_exporter"],
["dd_runtime_metrics_enabled", "otel_metrics_exporter"],
["dd_tags", "otel_resource_attributes"],
["dd_trace_otel_enabled", "otel_sdk_disabled"],
[ddlog_config, "otel_log_level"],
["dd_trace_sample_rate", otelsampler_config],
]:
for metric in otelHiding:
if (
f"config_datadog:{dd_config}" in metric["tags"]
and f"config_opentelemetry:{otel_config}" in metric["tags"]
):
assert metric["points"][0][1] == 1
break
else:
assert (
False
), f"Could not find a metric with {dd_config} and {otel_config} in otelHiding metrics: {otelHiding}"

@missing_feature(context.library == "dotnet", reason="Not implemented")
@missing_feature(context.library == "java", reason="Not implemented")
@missing_feature(context.library == "ruby", reason="Not implemented")
@missing_feature(context.library == "php", reason="Not implemented")
@missing_feature(context.library == "cpp", reason="Not implemented")
mabdinur marked this conversation as resolved.
Show resolved Hide resolved
@missing_feature(context.library == "python", reason="Not implemented")
@missing_feature(context.library == "does not collect env.invalid metrics for otel_resource_attributes", reason="nodejs")
@pytest.mark.parametrize(
"library_env",
[
Expand All @@ -360,6 +371,7 @@ def test_telemetry_otel_env_hiding(self, library_env, test_agent, test_library):
"OTEL_PROPAGATORS": "foo",
"OTEL_LOGS_EXPORTER": "foo",
"DD_TRACE_OTEL_ENABLED": None,
"DD_TRACE_DEBUG": None,
"OTEL_SDK_DISABLED": "foo",
}
],
Expand All @@ -375,30 +387,41 @@ def test_telemetry_otel_env_invalid(self, library_env, test_agent, test_library)

assert payload["namespace"] == "tracers"

otelHiding = [s for s in metrics if s["metric"] == "otel.env.hiding"]
otelInvalid = [s for s in metrics if s["metric"] == "otel.env.invalid"]

assert len(otelHiding) == 0
assert len(otelInvalid) == 8

expected_invalid_tags = [
["config_datadog:dd_trace_log_level", "config_opentelemetry:otel_log_level"]
if context.library == "nodejs"
else ["config_datadog:dd_log_level", "config_opentelemetry:otel_log_level"],
["config_datadog:dd_trace_propagation_style", "config_opentelemetry:otel_propagators"],
["config_datadog:dd_trace_sample_rate", "config_opentelemetry:otel_traces_sampler"],
["config_datadog:dd_trace_sample_rate", "config_opentelemetry:otel_traces_sampler_arg"],
["config_datadog:dd_trace_enabled", "config_opentelemetry:otel_traces_exporter"],
["config_datadog:dd_runtime_metrics_enabled", "config_opentelemetry:otel_metrics_exporter"],
["config_datadog:dd_trace_otel_enabled", "config_opentelemetry:otel_sdk_disabled"],
["config_opentelemetry:otel_logs_exporter"],
]

for expected in expected_invalid_tags:
assert any(all(tag in metric["tags"] for tag in expected) for metric in otelInvalid)

for metric in otelInvalid:
assert metric["points"][0][1] == 1
otel_invalid = [s for s in metrics if s["metric"] == "otel.env.invalid"]

if context.library == "nodejs":
ddlog_config = "dd_trace_log_level"
elif context.library == "python":
ddlog_config = "dd_trace_debug"
else:
ddlog_config = "dd_log_level"

if context.library == "python":
otelsampler_config = "otel_traces_sampler"
else:
otelsampler_config = "otel_traces_sampler_arg"

for dd_config, otel_config in [
["dd_trace_propagation_style", "otel_propagators"],
["dd_trace_sample_rate", "otel_traces_sampler"],
["dd_trace_enabled", "otel_traces_exporter"],
["dd_runtime_metrics_enabled", "otel_metrics_exporter"],
["dd_tags", "otel_resource_attributes"],
mabdinur marked this conversation as resolved.
Show resolved Hide resolved
["dd_trace_otel_enabled", "otel_sdk_disabled"],
[ddlog_config, "otel_log_level"],
["dd_trace_sample_rate", otelsampler_config],
[None, "otel_logs_exporter"],
]:
for metric in otel_invalid:
if (
dd_config is None or f"config_datadog:{dd_config}" in metric["tags"]
) and f"config_opentelemetry:{otel_config}" in metric["tags"]:
assert metric["points"][0][1] == 1
break
else:
assert (
False
), f"Could not find a metric with {dd_config} and {otel_config} in otel_invalid metrics: {otel_invalid}"


DEFAULT_ENVVARS = {
Expand Down
Loading