Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parametric: enable python otel env telemetry tests #3497

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

parametric: enable python otel env telemetry tests #3497

wants to merge 10 commits into from
+77 −52

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Nov 19, 2024 •
edited
Loading

Motivation

Enable Instrumentation Telemetry test for OpenTelemetry environment variable support.

Changes

  • Enable tests for python
  • Update tests to verify metric tags that are not set by ruby or golang.

TODO

  • The go, ruby, and nodejs tracers submit telemetry under different namespaces and set different tags for some otel enviornments. We will need to address these consistencies.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur marked this pull request as ready for review November 20, 2024 17:56
@mabdinur mabdinur requested review from a team as code owners November 20, 2024 17:56
@mabdinur mabdinur requested review from zacharycmontoya and removed request for a team November 20, 2024 17:56
robertomonteromiguel
robertomonteromiguel requested changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint failures

@mabdinur mabdinur mentioned this pull request Nov 22, 2024
Merged
2 tasks
@mabdinur
Copy link
Contributor Author

Blocked by: DataDog/dd-trace-py#11506

mabdinur added a commit to DataDog/dd-trace-py that referenced this pull request Nov 22, 2024
@mabdinur
chore(telemetry): fix namespace on otel metrics (#11506)
fff9f6c 
The namespace for otel metrics should be "tracers" and not "tracer". 

This regression was caught by system tests:
DataDog/system-tests#3497. No additional tests
are required.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharycmontoya zacharycmontoya Awaiting requested review from zacharycmontoya zacharycmontoya is a code owner automatically assigned from DataDog/apm-sdk-api

@robertomonteromiguel robertomonteromiguel Awaiting requested review from robertomonteromiguel

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabdinur @robertomonteromiguel