Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVML: Upgrade grpcio dep to address linux/arm64 build error #2078

Merged
merged 5 commits into from
Aug 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions nvml/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG - nvml

## 1.0.8 / 2023-08-14

* Upgrade grpcio dependency to solve some linux/arm64 build errors ([related issue](https://github.com/DataDog/integrations-extras/issues/1752)).

## 1.0.7 / 2023-06-07

***Fixed***:
Expand Down
2 changes: 1 addition & 1 deletion nvml/datadog_checks/nvml/__about__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# (C) Datadog, Inc. 2020-present
# All rights reserved
# Licensed under a 3-clause BSD style license (see LICENSE)
__version__ = '1.0.7'
__version__ = '1.0.8'
4 changes: 2 additions & 2 deletions nvml/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ dynamic = [

[project.optional-dependencies]
deps = [
"grpcio==1.27.2",
"pynvml==8.0.4",
"grpcio==1.57.0",
"pynvml==11.4.1",
]

[project.urls]
Expand Down
2 changes: 1 addition & 1 deletion nvml/requirements.in
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
pynvml==11.4.1
grpcio==1.27.2
grpcio==1.57.0
10 changes: 5 additions & 5 deletions nvml/tests/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# As the NVML integration is a community integration, it is not packaged with the Agent image by default. A custom image with the packaged integration should therefore be used in containerized environments.
# Setup taken from https://docs.datadoghq.com/agent/guide/use-community-integrations/?tab=docker

# Installs the NVML integration version 1.0.6.
# Installs the NVML integration version 1.0.8.
# See the changelog for the other versions that are available (https://github.com/DataDog/integrations-extras/blob/master/nvml/CHANGELOG.md)
FROM gcr.io/datadoghq/agent:latest
RUN agent integration install -t -r datadog-nvml==1.0.6
RUN agent integration install -t -r datadog-nvml==1.0.8

# Use the permalink to the requirements to install the PIP libraries used by the check
RUN curl https://raw.githubusercontent.com/DataDog/integrations-extras/c94cd62f61bcd763ae18a601f0862da308563c03/nvml/requirements.in > requirements.in && /opt/datadog-agent/embedded/bin/pip3 install -r requirements.in
# Use versioned link to the requirements to install the PIP libraries used by the check
RUN curl https://raw.githubusercontent.com/DataDog/integrations-extras/nvml-1.0.8/nvml/requirements.in > /tmp/requirements.in && /opt/datadog-agent/embedded/bin/pip3 install -r /tmp/requirements.in

# Why do you need these variables: See https://github.com/NVIDIA/nvidia-docker/wiki/Usage
ENV NVIDIA_VISIBLE_DEVICES all
ENV NVIDIA_DRIVER_CAPABILITIES all
ENV NVIDIA_DRIVER_CAPABILITIES all
Loading