Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NVML: Upgrade grpcio dep to address linux/arm64 build error #2078

Merged
merged 5 commits into from
Aug 23, 2023
Merged

NVML: Upgrade grpcio dep to address linux/arm64 build error #2078

merged 5 commits into from
Aug 23, 2023

Conversation

gaffneyd4
Copy link
Contributor

@gaffneyd4 gaffneyd4 commented Aug 14, 2023 •
edited
Loading

What does this PR do?

Update the grpcio dependency so integration will successfully build on linux/arm64 host. Also perform some small housekeeping changes that were observed.

Motivation

I needed to make this change to build the integration in my environment and wanted to pass along to fix to the next person who might need it: Comment describing the problem.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@gaffneyd4
Copy link
Contributor Author

Pinging maintainer @cep21 for review

@yzhan289
Copy link
Contributor

Thanks @cep21 and @gaffneyd4! 🙇

@yzhan289 yzhan289 merged commit 16e1bc9 into DataDog:master Aug 23, 2023
18 checks passed
@yzhan289 yzhan289 mentioned this pull request Aug 23, 2023
Open
nilslice pushed a commit to dylibso/integrations-extras that referenced this pull request Sep 28, 2023
@gaffneyd4 @nilslice
NVML: Upgrade grpcio dep to address linux/arm64 build error (DataDog#…
301cbad 
…2078)

* Upgrade grpcio dependency to solve some linux/arm64 build errors

* Changelog update

* Update dockerfile: ref latest version, use versioned reqs link

* Update to match latest value in requirements.in

* Bump version to 1.0.8
mgarabed added a commit that referenced this pull request Nov 6, 2023
@nilslice @estherk15
@emarsha94 @nmuesch @ofek @alpinet @moreauowen @yzhan289 @tmgstevens @gaffneyd4 @steveny91 @MahithaB @ChristineTChen @ruthnaebeck @jfrogsolutionci @MitaliBo @coignetp @drichards-87 @jd @yaodingyd @cgadde-uptycs @srinivas-bitla @vishalshah-dd @munahaf @llam15 @alai97 @humoflife @amiracle @criblben @jonny-scott80 @rtrieu @mgarabed
add Dylibso WebAssembly Observe SDK (#2073)
70c4fb8 
* add Dylibso WebAssembly Observe SDK

* fix: trailing comma in manifest.json

* fix: format CODEOWNERS

* fix: remove unused dashboard config

* fix: remove unused files and assets

* webassembly integration: address pr feedback

* update messaging to focus on traces

* additional trace-focus edit

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* fix: keep description in manifest within 80 char limit

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update webassembly-observe-sdk/README.md

Co-authored-by: Esther Kim <[email protected]>

* remove extra wasm observability image

* remove mention of log events in wasm observe integration

* Update CHANGELOG.md

Co-authored-by: emarsha94 <[email protected]>

* Update manifest.json

Co-authored-by: emarsha94 <[email protected]>

* Update manifest.json

Co-authored-by: emarsha94 <[email protected]>

* Update manifest.json

Co-authored-by: emarsha94 <[email protected]>

* fix: update dir name to match vendor name

* fix: update codeowners to reflect latest directory name

* Update dylibso-webassembly/README.md

Co-authored-by: emarsha94 <[email protected]>

* Update dylibso-webassembly/README.md

Co-authored-by: emarsha94 <[email protected]>

* Update dylibso-webassembly/README.md

Co-authored-by: emarsha94 <[email protected]>

* Migrate recommended monitor runs to new pipeline (#2074)

The recommended monitors are now being validated as part of the "validate-asset-monitors" check run, so stop running it through the now defunct `ddev validate recommended-monitors` method (which will be removed in the next version of ddev)

* Update changelog formatting (#2075)

* update lacework doc (#2080)

* add mongo db overview dashboard (#2081)

* add mongo db overview dashboard

* typo

* fix typo

* remove additional id field

* Adding new AI and ML categories to integrations (#2076)

* category updates

* adding more integrations

* Apply suggestions from code review

* Nudge CI

* Nudge CI

* Nudge CI

* fixing validations

* Sync validations

---------

Co-authored-by: Owen Moreau <[email protected]>
Co-authored-by: Andrew Zhang <[email protected]>

* Redpanda 2.0.0 - Update for public_metrics and Redpanda Cloud (#1864)

* Update to v2.0.0 and public_metrics endpoint

* Update following CI failures

* Convert histogram to distribution

* Update following CI failures

* Update following CI failures

* Updated with Redpanda contact details

* Fixing CPU busy time to seconds rather than milliseconds

* Change labels

* Fixup CHANGELOG.md

* Fixup CHANGELOG.md

* Fixup CHANGELOG.md

* Fixup CHANGELOG.md

* [Release] Update metadata

* NVML: Upgrade grpcio dep to address linux/arm64 build error (#2078)

* Upgrade grpcio dependency to solve some linux/arm64 build errors

* Changelog update

* Update dockerfile: ref latest version, use versioned reqs link

* Update to match latest value in requirements.in

* Bump version to 1.0.8

* [Release] Update metadata

* Add AI classifier tag (#2086)

* Upgrade Python version in CI (#2087)

* Update test-all.yml

* Jfrog platform 1.3.0 (#1895)

* Changed Dashboard to portrait format, rearranged widgets and added help text, updated title and documentation, updated screenshot

* Update jfrog_platform/manifest.json as per review

Co-authored-by: Christine Chen <[email protected]>

* Apply suggestions from code review

Co-authored-by: ruthnaebeck <[email protected]>

* Added datadog references as requested

* fixed ddev version and exported dashboard with latest format

* removed whitespace from screenshot

* Initial commit for JFrog Metrics

* added initial test and style checks

* tests for xray and conf

* Moving jfrog_metrics to a branch

* Adding jfrog_metrics

* Pushing in readme changes

* Adding changelog

* Adding changes to manifest.json

* Linking conf.yaml.example file to jfrog_metrics example file

* added dashboards json files and more metrics in metadata

* Adding readme links properly

* fixed all ci validations and some formatting

* adding artifactory dashboard.json

* adding artifactory image

* added xray dashboard

* added screenshots of dashboard and multiple housekeeping items

* fixing example config file

* fixing manifest validation check on linux

* Update jfrog_metrics/metadata.csv

Co-authored-by: Paul <[email protected]>

* applied suggestions for instancetype to be configurable in spec

* Update jfrog_metrics/README.md

Co-authored-by: Kaylyn <[email protected]>

* integrating metrics with jfrog platform

* adding metrics integrations and tests

* changed type in manifest

* fixing DD ci check

* Update jfrog_metrics/README.md

Co-authored-by: Kaylyn <[email protected]>

* fixing codecov yml

* cleaning up jfrog_metrics

* included metric_to_check

* Update jfrog_platform/datadog_checks/jfrog_platform/check.py

Co-authored-by: Paul <[email protected]>

* Update jfrog_platform/datadog_checks/jfrog_platform/check.py

Co-authored-by: Paul <[email protected]>

* Update jfrog_platform/datadog_checks/jfrog_platform/check.py

Co-authored-by: Paul <[email protected]>

* reverting tab changes in azure yaml

* fail integration if instance_type not given

* changelog order and tabs

* some formatting

* some formatting

* changing public tile name

* added xray integration

* readme changes

* Fixing changelog, pointing log-analytics-dd link to master, adding description in metadata.csv

* Adding readme changes, adding logs dashboard to assets, adding dashboard links to manifest.json

* Adding readme snippets from jfrog's log-analytics-datadog repo

* Updating dashboards, readme

* Using better image for xray logs

* Revert "added xray integration"

* JFrog Platform 1.3.0 version

* Setting sales email to [email protected]

* Renaming the target to jfrog_platform_self-hosted

* Removing checks and tests from codecov for jfrog_platform

* Fixing manifest new section failure

* Changing sourcetype name

* Update jfrog_platform_self-hosted/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update jfrog_platform_self-hosted/README.md

Co-authored-by: Esther Kim <[email protected]>

* Update jfrog_platform_self-hosted/README.md

Co-authored-by: Esther Kim <[email protected]>

* Adding readme changes as suggested, adding sales email to manifest

* Changes as per comments

* Adding datadog checks and readme table of contents

* Adding deprecation notice

* Changing dashboard keys and changing changelog

* Moving note above overview

* Changing gem based install formatting

* Changing deprecation wording

* Changing to alert

* Adding new dashboard layout, 16x9 aspect ratio images, readme corrections

* Changing deprecation date to august

* Removing installation steps from readme and adding links to github

* Adding linkchanges, wording changes

* Changing the changelog name

* Changing changelog format

* Changing codeowners file with jfrog_platform_self-hosted integration name

* Renaming folder name, adding servie_checks back

* Adding new integration name to codecov

* Adding configuration/spec back

* Adding spec.yaml back

* Adding spec to manifest.json and fixing spec name

* Adding setup.py file back

* Moving service checks inside integrations in manifest.json

* Fixing space in changelog

* Readme changes

* Adding dashboards with standard attribute data

* Changing deprecation date to Oct 31st

---------

Co-authored-by: Vinay Aggarwal <[email protected]>
Co-authored-by: Christine Chen <[email protected]>
Co-authored-by: ruthnaebeck <[email protected]>
Co-authored-by: Mitali <[email protected]>
Co-authored-by: Mitali <[email protected]>
Co-authored-by: Mitali Bisht <[email protected]>
Co-authored-by: Paul <[email protected]>
Co-authored-by: Kaylyn <[email protected]>
Co-authored-by: Esther Kim <[email protected]>

* Fix code coverage configuration file (#2090)

* Fix environment config

* Add blog link for Instabug integration (#2092)

* Add blog link

* Add blog post link

* fix(mergify): raise timeout error rather than returning None (#2084)

The current behaviour is to return None which triggers an error later in the
code:

[{"message": "'NoneType' object is not subscriptable", "traceback": "Traceback (most recent call last):
  File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/base/checks/base.py", line 1142, in run
    self.check(instance)
  File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/mergify/check.py", line 29, in check
    self.send_queues_metrics()
  File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/mergify/check.py", line 86, in send_queues_metrics
    for queue in response_json["queues"]:
TypeError: 'NoneType' object is not subscriptable
"}]

This implements the same behaviour than the other errors, being raising back
the error to the caller.

* Fixing broken URL's in xray dashboards (#2091)

* Fix blog link (#2093)

* Update all monitor assets to v2 schema (#2077)

* update to v2

* Update packet-loss-monitor.json

* Update high-latency-monitor.json

* update

* fix unicode <>

* initial pull request for Uptycs-DataDog integration (#2046)

* initial commit

* update readme

* add Uptycs events dashboard

* update UI screenshots and steps

* address comments and update dashboard

* update readme

* remove non-ascii char from readme

* update dashboard screenshots

* update suggestions

* dashboard updated

* Release lighthouse (#2101)

* [Release] Update metadata

* Add missing pyproject and update version of JFrog (#2102)

* [Release] Update metadata

* Updated support email ids, added additional images, and some small improvements. (#2094)

* Updated support email ids, added additional images and some small improvements.

* Added review recommendation.

* Synchronise integrations with logs-backend (#2106)

Co-authored-by: Nicholas Muesch <[email protected]>

* Comment: Fixed an inappropriate test expression to remove a logical short circuit. (#2104)

* Create Sym Integration Tile (#2058)

* Create Sym Tile

* Apply code review requested changes

* update dashboard description, add logo to dashboard

* Apply suggestions from code review

Co-authored-by: Austin Lai <[email protected]>

* Add uninstallation section, apply code review comments

* crop dashboard preview image

* update uninstallation instructions

* Update sym/README.md

Co-authored-by: owen moreau <[email protected]>

* Update dashboard JSON to use new facets

* add space to changelog

---------

Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: owen moreau <[email protected]>

* Create integration for ngrok (#2105)

* Create integration for ngrok

* Typo

* Add Service checks

* Upbound uxp (#1892)

* upbound_uxp agent integration foundation

* added autogenerated validations

* added conf.yaml examples

* added dashboards

* updated README.md

* updated conf.yaml.example

* added logo svg

* updated homepage and sales email in manifest

* updated description, media link, relevant categories, metrics check

* deleted images/IMAGES_README.md

* updated CHANGELOG.md and README.md

* updated author email distribution alias

* updated json

* added metric check prefix

* added image to images folder and updated manifest

* upgrade to python 3.9

* added py3.9 libs

* added kubernetes >= 26.1.0 dependency

* installing kind on demand during tests

* updated CHANGELOG.md and manifest.json

* removed Category::Languages from manifest.json

* accept alternative DD_API_KEY and DD_APP_KEY env vars

* replaced print statements with self.log

* removed version from check.py because it is in __about.py__

* added __version__ import

* updated README.md

* updated typo

* added dashboard images

* added metadata info

* updated metadata metric_type fields

* updated can_connect prefix

* updated can_connect prefix

* added monitor

* removed saved_views from manifest

* updated ci validation

* added .codecov.yml

* updated README.md

* reformatted Datadog dashboard json export

* updated workflows test-all.yml

* added code owner for upbound_uxp

* updated upbound_uxp CODEOWNERS info

* updated CODEOWNERS file

* deduplicated line in CODEOWNERS

* updated assets path

* skipping codeowners validation while awaiting guidance

* updated spec name

* added metadata column

* added column in metadata to can_connect

* added default orientation to metadata.csv

* added pyproject name datadog-upbound-uxp

* added recommended_monitor_metadata

* added monitor integraion tag

* updated service check arrays

* updated service_checks integration name

* updated manifest and README

* replaced tabs with spaces

* added codeowners validation

* added external logo link and updated dashboard description

* Updated README.md

* updated env exports

* prefixed forbidden host and version tags

* Added agent status info

* updated formatting

* updated sentence

* omitted checking for Datadog API and APP keys (temporarily)

* iterating on test setup

* checking if dd test can create kind cluster

* added kind-uxp context

* refactor b/c no API key and py3.9

* added timeout

* updated syntax

* dynamic namespace use

* updated models

* trying python 3.8

* added http timeouts

* rolled back tooling per Datadog guidance to enable tests to work locally

* work in progress mock tests

* added mock tests

* pinned ddev to 3.1.0

* skipping e2e tests

* deleted junit test

* removed k8s test harness. covered by mock tests

* removed dd_environment_k8s

* added spaces for Datadog README parser

* get_metrics indentation update

* replace --- with individual sections

* added info to conf.yaml.example

* reverted conf.yaml.example b/c of dd github tests

* updated montior to v2 format

---------

Co-authored-by: Markus Schweig <[email protected]>

* [Release] Update metadata

* Update README.md (#2110)

* Update README.md

Updated the integration build and deployment instructions.

* Update README.md

Added installation instructions for non-developers.

* Update README.md

Removed installation for developers per Datadog guidance.

* Update README.md

* Update README.md

* Update README.md

* Update upbound_uxp/README.md

Co-authored-by: DeForest Richards <[email protected]>

---------

Co-authored-by: Ana Wishnoff <[email protected]>
Co-authored-by: DeForest Richards <[email protected]>

* Sofy Integration Further Reading Update (#2113)

* Update Further Reading

* Update Link

Co-authored-by: DeForest Richards <[email protected]>

---------

Co-authored-by: DeForest Richards <[email protected]>

* Cribl Stream initial commit (#1801)

* Cribl Stream initial commit

* Initial Cribl Commit

* Update manifest.json

repaired manifest.json to conform to datadog library.

* Create datadog-synthetics.yml

* Update CODEOWNERS

added cribl to CODEOWNERS

* Update README.md

added full path for images and removed non-ASCII characthers (-).

* added cribl-terms-of-service-204.pdf

This is a PDF of Cribl's Terms of Service found at https://cribl.io/legal/terms/ . The current version as of August 2023 was v.2.04, please check the site for updated versions of the TOS.

* Update manifest.json

updated legal and eula

* Update manifest.json

Modified email addresses

* Update manifest.json

moved legal terms out of assets array

* Update manifest.json

moved service check out of asset array.

* Update manifest.json

updated metrics checks added period (.) to prefix and moved sercice_checks back into the Assets array. Added the integration array.

* Update manifest.json

moved dashboards out of integration

* fixed metadata.csv file

* removed non-utf8 code

* removed datadog-synthetic file

* add panels for context on values

* updated stream png

* Update manifest.json

Removed Legal Object terms.

* Updated Files for Merge

Updated Dashboard with descriptions for all frames. Updated metadata.json and removed legal field. Updated metadata.csv and replaced counter with count.

* updated metadata.csv

removed space in metadata.csv

* Update metadata.csv

Fixed spaces in metadata.csv

* Update metadata.csv

Removed redundant metric field.

* Update metadata.csv

Removed redundant metric 'cribl.logstream.host.in_events'

* Update metadata.csv

Removed additional duplicates.

* Update metadata.csv

Added comma

* Update metadata.csv

Fixing formatting to pass validation.

* Update metadata.csv

Added Orientation value.

* Update metadata.csv

Updated metada with proper fields, removed spaces and added orientation.

---------

Co-authored-by: Ben Marcus <[email protected]>

* Update version of upbound_uxp (#2116)

Updated __version__ to 1.0.0 from 0.0.1 per Datadog guidance.

* [Release] Update metadata

* Updating integration categories (#2109)

* updating categories

* adding data store changes

* Nudge CI

---------

Co-authored-by: Nicholas Muesch <[email protected]>

* Add Wayfinder integration (#1944)

* Add Wayfinder integration

* Disable e2e test environment

* Updated readme inline with review comment

* Update readme following review

* Update readme spelling

Co-authored-by: Rosa Trieu <[email protected]>

* Another readme update

* Updates suggested in PR review (#2)

* test

* test

* test

* readd assets

* Image and manifest updates

* Image and manifest updates

* Updated dashboard image

* Address PR comments. Fix test issue

* Fix formatting

* Fix another validation error

* Revert - Fix anothe validation error

* update config models

* fix another new issue with tests

* rename logo file

* Attempt to fix asset validation - update tile title

* Updated author details to Appvia

* Update config model

* revert config change

* Updated dashboard titles

---------

Co-authored-by: Rosa Trieu <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>

* [Release] Update metadata

* fix: update CODEOWNERS to match other integrations

* fix: dylibso_wasm reference metadata.csv in codeowners

* Update .github/CODEOWNERS

Co-authored-by: emarsha94 <[email protected]>

* Update .github/CODEOWNERS

Co-authored-by: emarsha94 <[email protected]>

* remove file, fix validation error

* fix: correct dylibso integration image url

Co-authored-by: Mike Garabedian <[email protected]>

---------

Co-authored-by: Esther Kim <[email protected]>
Co-authored-by: emarsha94 <[email protected]>
Co-authored-by: Nicholas Muesch <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: alpinet <[email protected]>
Co-authored-by: Ana Wishnoff <[email protected]>
Co-authored-by: Owen Moreau <[email protected]>
Co-authored-by: Andrew Zhang <[email protected]>
Co-authored-by: Tristan Stevens <[email protected]>
Co-authored-by: ci.integrations-extras <[email protected]>
Co-authored-by: Derek Gaffney <[email protected]>
Co-authored-by: Steven Yuen <[email protected]>
Co-authored-by: Mahitha Byreddy <[email protected]>
Co-authored-by: Vinay Aggarwal <[email protected]>
Co-authored-by: Christine Chen <[email protected]>
Co-authored-by: ruthnaebeck <[email protected]>
Co-authored-by: Mitali <[email protected]>
Co-authored-by: Mitali <[email protected]>
Co-authored-by: Mitali Bisht <[email protected]>
Co-authored-by: Paul <[email protected]>
Co-authored-by: Kaylyn <[email protected]>
Co-authored-by: DeForest Richards <[email protected]>
Co-authored-by: Julien Danjou <[email protected]>
Co-authored-by: Yao Ding <[email protected]>
Co-authored-by: Chandrasekhar Gadde <[email protected]>
Co-authored-by: srinivas-bitla <[email protected]>
Co-authored-by: Vishal Shah <[email protected]>
Co-authored-by: Munawar <[email protected]>
Co-authored-by: Leslie Lam <[email protected]>
Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: owen moreau <[email protected]>
Co-authored-by: Philippe Beaudequin <[email protected]>
Co-authored-by: humoflife <[email protected]>
Co-authored-by: Markus Schweig <[email protected]>
Co-authored-by: humoflife <[email protected]>
Co-authored-by: Kamilo Amir <[email protected]>
Co-authored-by: Ben Marcus <[email protected]>
Co-authored-by: Jonny Scott <[email protected]>
Co-authored-by: Rosa Trieu <[email protected]>
Co-authored-by: Mike Garabedian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cep21 cep21 cep21 approved these changes

@yzhan289 yzhan289 yzhan289 approved these changes

Assignees
No one assigned
Labels
agent/approved docs/review-requested ecosystems/review-requested product/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaffneyd4 @yzhan289 @cep21