Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert an integration test to unit test. #18438

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Convert an integration test to unit test. #18438

merged 2 commits into from
Aug 28, 2024

Commits on Aug 28, 2024

  1. Convert an integration test to unit test. 

    This test's flakiness wasn't worth the value it was delivering, i.e. testing
that the requests lib respects the timeout.

We've refocused the test on checking that we provide the timeout correctly to
requests and that we let the timeout error bubble up.
    @iliakur
    iliakur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7d668cd View commit details
    Browse the repository at this point in the history

  2. add changelog

    @iliakur
    iliakur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9ca8982 View commit details
    Browse the repository at this point in the history