Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert an integration test to unit test. #18438

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Aug 28, 2024

What does this PR do?

Along the way also add optional kwarg to override the session attribute of RequestsWrapper.

Motivation

This test's flakiness wasn't worth the value it was delivering, i.e. testing
that the requests lib respects the timeout.

We've refocused the test on checking that we provide the timeout correctly to
requests and that we let the timeout error bubble up.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

This test's flakiness wasn't worth the value it was delivering, i.e. testing
that the requests lib respects the timeout.

We've refocused the test on checking that we provide the timeout correctly to
requests and that we let the timeout error bubble up.
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.55%. Comparing base (9bf5113) to head (9ca8982).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory 72.72% <ø> (ø)
activemq 52.80% <ø> (ø)
activemq_xml 82.31% <ø> (ø)
amazon_msk 88.91% <ø> (ø)
ambari 85.80% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.23% <ø> (ø)
argo_rollouts 90.00% <ø> (ø)
argo_workflows 87.87% <ø> (ø)
argocd 87.81% <ø> (ø)
aspdotnet 100.00% <ø> (ø)
avi_vantage 91.35% <ø> (ø)
aws_neuron 92.42% <ø> (ø)
azure_iot_edge 82.08% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
calico 84.61% <ø> (ø)
cassandra 66.66% <ø> (ø)
cert_manager 77.41% <ø> (ø)
cisco_aci 94.95% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
cloud_foundry_api 96.11% <ø> (ø)
cloudera 99.51% <ø> (ø)
cockroachdb 93.19% <ø> (ø)
consul 91.82% <ø> (ø)
coredns 94.61% <ø> (ø)
couch 94.74% <ø> (+1.28%) ⬆️
crio 89.79% <ø> (ø)
datadog_checks_base 88.97% <100.00%> (+0.29%) ⬆️
datadog_checks_dev 77.33% <ø> (ø)
datadog_checks_downloader 81.35% <ø> (+3.23%) ⬆️
datadog_cluster_agent 90.19% <ø> (ø)
dcgm 92.10% <ø> (ø)
ddev 87.28% <ø> (ø)
directory 95.24% <ø> (ø)
disk 89.34% <ø> (ø)
dns_check 93.33% <ø> (ø)
druid 97.70% <ø> (ø)
ecs_fargate 83.52% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
esxi 93.05% <ø> (ø)
etcd 95.56% <ø> (ø)
external_dns 89.28% <ø> (ø)
fluentd 84.32% <ø> (ø)
fluxcd 88.31% <ø> (ø)
foundationdb 83.83% <ø> (ø)
gitlab_runner 92.10% <ø> (ø)
go_expvar 92.73% <ø> (ø)
gunicorn 92.16% <ø> (-0.75%) ⬇️
hazelcast 92.39% <ø> (ø)
hdfs_datanode 89.74% <ø> (ø)
hdfs_namenode 86.72% <ø> (ø)
hive 51.42% <ø> (ø)
hivemq 61.90% <ø> (ø)
http_check 93.29% <ø> (ø)
hudi ?
ibm_db2 86.87% <ø> (ø)
ibm_i 81.91% <ø> (ø)
ibm_mq 91.15% <ø> (+43.16%) ⬆️
ignite 46.66% <ø> (ø)
impala 97.97% <ø> (ø)
istio 77.63% <ø> (ø)
jboss_wildfly 47.36% <ø> (ø)
kafka 64.70% <ø> (ø)
karpenter 94.36% <ø> (ø)
kong 87.62% <ø> (ø)
kube_apiserver_metrics 97.74% <ø> (ø)
kube_controller_manager 97.89% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 97.92% <ø> (ø)
kubelet 91.01% <ø> (ø)
kubernetes_cluster_autoscaler 93.22% <ø> (ø)
kubernetes_state 89.50% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
kyverno 82.27% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 84.09% <ø> (ø)
linux_proc_extras 96.22% <ø> (ø)
mapr 82.42% <ø> (ø)
mapreduce 82.08% <ø> (ø)
marathon 83.12% <ø> (ø)
mcache 93.50% <ø> (ø)
mesos_master 89.81% <ø> (ø)
mesos_slave 93.31% <ø> (ø)
mysql 22.65% <ø> (ø)
nagios 89.01% <ø> (ø)
network 92.60% <ø> (ø)
nfsstat 95.20% <ø> (ø)
nginx 94.54% <ø> (ø)
nginx_ingress_controller 98.36% <ø> (ø)
nvidia_triton 88.52% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 98.08% <ø> (ø)
openstack 55.19% <ø> (ø)
pgbouncer 91.35% <ø> (ø)
php_fpm 89.71% <ø> (ø)
postfix 88.10% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
presto 59.09% <ø> (ø)
process 85.61% <ø> (ø)
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
pulsar 100.00% <ø> (ø)
ray 96.45% <ø> (ø)
redisdb 87.77% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
riak 99.21% <ø> (ø)
riakcs 87.71% <ø> (ø)
silk 93.82% <ø> (ø)
singlestore 90.81% <ø> (ø)
snowflake 96.27% <ø> (ø)
solr 56.25% <ø> (ø)
spark 93.87% <ø> (-0.28%) ⬇️
sqlserver 24.14% <ø> (ø)
squid 100.00% <ø> (ø)
ssh_check 91.66% <ø> (ø)
statsd 87.36% <ø> (ø)
supervisord 89.78% <ø> (ø)
system_core 92.66% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 90.39% <ø> (ø)
teamcity 84.82% <ø> (ø)
tekton 82.30% <ø> (ø)
teleport 99.61% <ø> (ø)
temporal 100.00% <ø> (ø)
teradata 94.05% <ø> (ø)
tibco_ems 91.98% <ø> (ø)
tls 91.16% <ø> (ø)
tokumx 57.52% <ø> (ø)
torchserve 97.32% <ø> (ø)
traefik_mesh 76.75% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twemproxy 79.56% <ø> (ø)
twistlock 80.47% <ø> (ø)
varnish 84.12% <ø> (ø)
vllm 93.10% <ø> (ø)
vsphere 96.15% <ø> (ø)
weaviate 76.27% <ø> (ø)
win32_event_log 81.55% <ø> (ø)
wmi_check 97.50% <ø> (ø)
yarn 89.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@iliakur iliakur merged commit 02fb739 into master Aug 28, 2024
358 of 368 checks passed
@iliakur iliakur deleted the ik/fix-base-pkg-test branch August 28, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants