Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM support for iast #5012

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

ESM support for iast #5012

wants to merge 18 commits into from

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Dec 13, 2024

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

@uurien uurien force-pushed the ugaitz/partial-esm-support-iast branch from cf989f5 to a7a0b49 Compare December 13, 2024 17:21
Copy link

github-actions bot commented Dec 13, 2024

Overall package size

Self size: 8.49 MB
Deduped: 94.85 MB
No deduping: 95.37 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Dec 13, 2024

Benchmarks

Benchmark execution time: 2025-01-20 15:42:57

Comparing candidate commit bcf336d in PR branch ugaitz/partial-esm-support-iast with baseline commit 9e36df0 in branch master.

Found 0 performance improvements and 15 performance regressions! Performance is the same for 861 metrics, 27 unstable metrics.

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-22

  • 🟥 cpu_user_time [+337.456ms; +361.423ms] or [+32.222%; +34.510%]
  • 🟥 execution_time [+388.110ms; +410.737ms] or [+32.651%; +34.555%]
  • 🟥 max_rss_usage [+35.345MB; +38.538MB] or [+29.855%; +32.552%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-22

  • 🟥 cpu_user_time [+335.377ms; +354.461ms] or [+32.796%; +34.662%]
  • 🟥 execution_time [+397.628ms; +414.028ms] or [+34.240%; +35.652%]
  • 🟥 max_rss_usage [+34.943MB; +38.672MB] or [+29.653%; +32.817%]

scenario:appsec-iast-startup-time-iast-enabled-22

  • 🟥 cpu_user_time [+327.674ms; +348.683ms] or [+23.720%; +25.241%]
  • 🟥 execution_time [+389.460ms; +407.883ms] or [+24.686%; +25.854%]
  • 🟥 max_rss_usage [+35.548MB; +38.399MB] or [+26.361%; +28.475%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-22

  • 🟥 cpu_user_time [+343.382ms; +383.431ms] or [+23.467%; +26.204%]
  • 🟥 execution_time [+456.847ms; +514.272ms] or [+22.955%; +25.841%]
  • 🟥 max_rss_usage [+36.299MB; +40.062MB] or [+26.927%; +29.718%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-22

  • 🟥 cpu_user_time [+343.970ms; +377.296ms] or [+26.260%; +28.804%]
  • 🟥 execution_time [+454.636ms; +508.219ms] or [+25.853%; +28.900%]
  • 🟥 max_rss_usage [+34.763MB; +37.782MB] or [+26.760%; +29.085%]

@uurien uurien force-pushed the ugaitz/partial-esm-support-iast branch from 6e58b62 to afe2591 Compare December 16, 2024 11:04
@uurien uurien force-pushed the ugaitz/partial-esm-support-iast branch 2 times, most recently from 69c5b4a to dffcd70 Compare December 16, 2024 17:11
@uurien uurien force-pushed the ugaitz/partial-esm-support-iast branch 4 times, most recently from 124dc6b to e995278 Compare January 14, 2025 13:23
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.54%. Comparing base (4886c38) to head (e995278).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5012       +/-   ##
===========================================
- Coverage   79.95%   63.54%   -16.42%     
===========================================
  Files         291       39      -252     
  Lines       13631     1805    -11826     
===========================================
- Hits        10899     1147     -9752     
+ Misses       2732      658     -2074     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uurien uurien force-pushed the ugaitz/partial-esm-support-iast branch 5 times, most recently from 03b53f1 to 2552fb3 Compare January 14, 2025 15:35
@uurien uurien force-pushed the ugaitz/partial-esm-support-iast branch from 7b42e04 to 9bd0b62 Compare January 15, 2025 08:31
@uurien uurien force-pushed the ugaitz/partial-esm-support-iast branch from c3f77d7 to bcf336d Compare January 20, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant