Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] Use --import instead of --require in nextjs app #3698

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

uurien
Copy link
Contributor

@uurien uurien commented Dec 16, 2024

Motivation

DataDog/dd-trace-js#5012 will start using esm loader, which is executed in a different worker and makes some test failures because there are more RC calls than expected.
With this change that behaviour will be fixed.

Changes

use --import instead of --require to initialize the tracer.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@uurien uurien changed the title Use initialize instead of --require in nextjs app Use --import instead of --require in nextjs app Dec 16, 2024
@uurien uurien changed the title Use --import instead of --require in nextjs app [nodejs] Use --import instead of --require in nextjs app Dec 17, 2024
@uurien uurien force-pushed the ugaitz/use-initialize-in-nextjs branch from 2d3ea83 to 7f46d31 Compare January 15, 2025 09:29
@uurien uurien force-pushed the ugaitz/use-initialize-in-nextjs branch from 7f46d31 to 167c285 Compare January 17, 2025 16:17
@uurien uurien marked this pull request as ready for review January 20, 2025 14:45
@uurien uurien requested review from a team as code owners January 20, 2025 14:45
@uurien uurien merged commit 226b51c into main Jan 20, 2025
49 checks passed
@uurien uurien deleted the ugaitz/use-initialize-in-nextjs branch January 20, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants