-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove get-port usage from http tests and test agent #4426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 6.71 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4426 +/- ##
===========================================
- Coverage 92.64% 63.75% -28.90%
===========================================
Files 116 249 +133
Lines 4173 10825 +6652
Branches 33 33
===========================================
+ Hits 3866 6901 +3035
- Misses 307 3924 +3617 ☔ View full report in Codecov by Sentry. |
Qard
approved these changes
Jun 21, 2024
This was referenced Jun 22, 2024
juan-fernandez
pushed a commit
that referenced
this pull request
Jul 10, 2024
* remove get-port usage from http tests and test agent * move test tracer init after port allocation
juan-fernandez
pushed a commit
that referenced
this pull request
Jul 10, 2024
* remove get-port usage from http tests and test agent * move test tracer init after port allocation
juan-fernandez
pushed a commit
that referenced
this pull request
Jul 11, 2024
* remove get-port usage from http tests and test agent * move test tracer init after port allocation
juan-fernandez
pushed a commit
that referenced
this pull request
Jul 11, 2024
* remove get-port usage from http tests and test agent * move test tracer init after port allocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove get-port usage from http tests and test agent.
Motivation
We often see flakiness from race conditions between getting and using available ports. Node can do this for us, so when possible we should rely on
server.listen
to do both steps at the same time for us, removing the possibility of a race condition. This should alleviate most of the seemingly randomEADDRINUSE
errors in tests.Additional Notes
Since get-port is used in many other places, it's possible that we still get the issue, at which point it should also be removed from any other problematic tests.