Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove most get-port usage in appsec tests #4428

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jun 22, 2024

What does this PR do?

Remove most get-port usage in AppSec tests.

Motivation

Follow-up of #4426

Additional Notes

The only usage left is in Next plugin test because it sends the port to an external process. If that test could be refactored to avoid doing this, then AppSec tests could be completely free of get-port.

Copy link

github-actions bot commented Jun 22, 2024

Overall package size

Self size: 6.71 MB
Deduped: 61.97 MB
No deduping: 62.25 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.8.1 71.67 kB 741.34 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jun 22, 2024

Benchmarks

Benchmark execution time: 2024-06-22 19:16:19

Comparing candidate commit 511b926 in PR branch remove-appsec-get-port with baseline commit f29f416 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics.

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.42%. Comparing base (b1f1f85) to head (5107046).
Report is 5 commits behind head on master.

Current head 5107046 differs from pull request most recent head 511b926

Please upload reports for the commit 511b926 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4428       +/-   ##
===========================================
- Coverage   92.64%   80.42%   -12.22%     
===========================================
  Files         116        3      -113     
  Lines        4173      373     -3800     
  Branches       33       33               
===========================================
- Hits         3866      300     -3566     
+ Misses        307       73      -234     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rochdev rochdev marked this pull request as ready for review June 22, 2024 16:58
@rochdev rochdev requested a review from a team as a code owner June 22, 2024 16:58
Copy link
Collaborator

@uurien uurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only usage left is in Next plugin test because it sends the port to an external process

I'll take a look at this today


edit:
in a quick check, It seems that it is not possible for standalone nextjs tests, in the compiled files I can see this:

const currentPort = parseInt(process.env.PORT, 10) || 3000

If we don't define the port externally, the app will use 3000, if it is not free, it will fail.

@rochdev rochdev merged commit 0ec0653 into master Jun 24, 2024
135 checks passed
@rochdev rochdev deleted the remove-appsec-get-port branch June 24, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants