Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force SRContentClip to be applied on texts #572

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Force SRContentClip to be applied on texts #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react-native-session-replay/ios/Sources/RCTTextViewRecorder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,10 @@ internal struct RCTTextViewWireframesBuilder: SessionReplayNodeWireframesBuilder

// Clipping should be 0 to avoid the text from overflowing when the
// numberOfLines prop is used.
// To apply clip(0 0 0 0) we set a negative clipping (which has no effect).
// TODO: RUM-2354 remove this when clip(0 0 0 0) is applied
private var clip: SRContentClip {
let top = 0.0
let top = -1.0
let left = 0.0
let bottom = 0.0
let right = 0.0
Expand Down