Force SRContentClip to be applied on texts #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejburda
approved these changes
Jan 2, 2024
jonathanmos
approved these changes
Jan 3, 2024
louiszawadzki
deleted the
louiszawadzki/rum-2354/set-text-clip-to-fix-ellipsis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Today the
clip(0 0 0 0)property is not set as this is the value used to remove the clip path.There is a plan to tackle this in the player and in SDK. However this probably won't be ready for our private beta phase, so in the meantime I suggest a small temporary change to allow a better
Force the
clip(0 0 0 0)property to be applied on Texts.Setting a negative clip value does not change anything visually, but it ensures that the clipping is set.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)