Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-4412] Upgrade k8s dependencies #1445

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Oct 1, 2024

What does this PR do?

Update kubernetes and related dependencies.

Motivation

We need to update datadog-operator to be able to update in datadog-agent.

Additional Notes

PodSecurityPolicy has been dropped upstream by kubernetes/api@5a75c6e.

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@L3n41c L3n41c added the dependencies Pull requests that update a dependency file label Oct 1, 2024
@L3n41c L3n41c added this to the v1.10.0 milestone Oct 1, 2024
@L3n41c L3n41c requested review from a team as code owners October 1, 2024 16:27

toolchain go1.22.7

require (
github.com/DataDog/datadog-api-client-go/v2 v2.27.0
github.com/DataDog/extendeddaemonset v0.10.0-rc.4
github.com/DataDog/extendeddaemonset v0.9.0-rc.3.0.20240930151437-dfe15f763532
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be updated once DataDog/extendeddaemonset#192 is merged.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 49.48%. Comparing base (6dc343d) to head (93ce5e4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
api/k8s.io/policy/v1beta1/register.go 0.00% 4 Missing ⚠️
pkg/equality/equality.go 0.00% 2 Missing ⚠️
cmd/main.go 0.00% 1 Missing ⚠️
pkg/plugin/common/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1445      +/-   ##
==========================================
+ Coverage   49.01%   49.48%   +0.46%     
==========================================
  Files         223      225       +2     
  Lines       19501    19694     +193     
==========================================
+ Hits         9559     9745     +186     
- Misses       9453     9454       +1     
- Partials      489      495       +6     
Flag Coverage Δ
unittests 49.48% <33.33%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/k8s.io/policy/v1beta1/types.go 100.00% <100.00%> (ø)
...nal/controller/datadogagent/merger/pod_security.go 0.00% <ø> (ø)
.../controller/datadogagent/testutils/client_utils.go 100.00% <100.00%> (ø)
pkg/kubernetes/objects.go 0.00% <ø> (ø)
pkg/kubernetes/objectslist.go 0.00% <ø> (ø)
cmd/main.go 0.00% <0.00%> (ø)
pkg/plugin/common/client.go 0.00% <0.00%> (ø)
pkg/equality/equality.go 11.62% <0.00%> (ø)
api/k8s.io/policy/v1beta1/register.go 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc343d...93ce5e4. Read the comment docs.

"sigs.k8s.io/controller-runtime/pkg/scheme"
)

var (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we kind of vendoring PSP type because Operator has a compile-time dependency which isn't compatible with the 1.31 k8s version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants