Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-4412] Upgrade k8s dependencies #221

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Oct 3, 2024

What does this PR do?

Update kubernetes and related dependencies.

Motivation

We need to update watermarkpodautoscaler to be able to update in datadog-agent.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@L3n41c L3n41c requested a review from a team as a code owner October 3, 2024 15:20
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@L3n41c L3n41c added the dependencies Pull requests that update a dependency file label Oct 3, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 3, 2024

require (
github.com/DataDog/datadog-operator v1.3.0
github.com/go-logr/logr v1.3.0
github.com/DataDog/datadog-operator v0.7.1-0.20241003091406-6e9e14d97438
Copy link
Collaborator

@clamoriniere clamoriniere Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this tag correspond to main?
can we use v1.8.0 ? or v1.9.0-rc.3 maybe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag corresponds to the opened PR DataDog/datadog-operator#1445 because I preferred to have all the dependencies aligned and avoid having a bunch of different versions for a given dependency (like k8s.io modules) depending on the path that pulls it.

So, this will need to be updated to a main commit as soon as DataDog/datadog-operator#1445 will be merged.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

github-actions[bot]
github-actions bot previously approved these changes Oct 7, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 8, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 8, 2024
@L3n41c L3n41c added this to the 0.8.0 milestone Oct 9, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 9, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants