Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transitions requiring multiple actors #263
Transitions requiring multiple actors #263
Changes from 10 commits
3afe48d
c6fc451
1548c7f
b96f20d
ddec2bc
1872a90
8eaa2f3
b85602a
68a82c1
1c692b1
cdc9b93
d2c126f
1c2d5b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't really matter now that @jessesnyder has fixed the client side bug in handling zero-calorie non-interactive items, but I think this should probably be
interactive: true
, since the fallen stag is likely to be a useful item and is not immediately edible. I believe thatinteractive: false
is primarily intended for Pac Man™ style legacy food-type items.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea here is that consuming the stag provides a total of 20 calories, split evenly among the participants (with the initiator getting any remainder), and what's left is a fallen stag which may have separate uses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should have another example multi-actor transition with no calories, but results in an object with multiple available uses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alecpm You're correct about what the idea is.
Items added to this file are effective in the game. I can add one more example, but it should probably be a "real" one. Or maybe I misunderstood your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it would be good to have a "real" example of such a transition, but such transitions are the second checkbox on #235. So I think we'd ideally have such an example available. Maybe best to ask Natalia for one?
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.