Transitions requiring multiple actors #263
Conversation
… into issue/238-multi-participant-trans
silviot
changed the title
… into issue/238-multi-participant-trans
…a stag with a sharp stone
| target_end: fallen_stag | ||
| visible: always | ||
| last_use: false | ||
| calories: 20 |
There was a problem hiding this comment.
The idea here is that consuming the stag provides a total of 20 calories, split evenly among the participants (with the initiator getting any remainder), and what's left is a fallen stag which may have separate uses?
There was a problem hiding this comment.
Maybe we should have another example multi-actor transition with no calories, but results in an object with multiple available uses?
There was a problem hiding this comment.
@alecpm You're correct about what the idea is.
Items added to this file are effective in the game. I can add one more example, but it should probably be a "real" one. Or maybe I misunderstood your suggestion.
There was a problem hiding this comment.
I agree it would be good to have a "real" example of such a transition, but such transitions are the second checkbox on #235. So I think we'd ideally have such an example available. Maybe best to ask Natalia for one?
There was a problem hiding this comment.
Tested this and most of it is working well, but somehow the "fallen stag" doesn't end up in the grid as expected. It's not clear what's going on to me. What's especially weird is that the handbag emoji seems to randomly appear and disappear from the slot where it should be, though I never see indication in the UI that the "fallen stag" is at the location. Maybe @jessesnyder will have some insight.
There was a problem hiding this comment.
This worked well for me. I did track down the bug @alecpm had found with the re-appearing handbag 👜, and made a commit for that.
Up to you on what to do or not do about my JS idea.
dlgr/griduniverse/game_config.yml
Outdated
| item_id: fallen_stag | ||
| n_uses: 1 | ||
| sprite: "emoji:👜" | ||
| interactive: false |
There was a problem hiding this comment.
It doesn't really matter now that @jessesnyder has fixed the client side bug in handling zero-calorie non-interactive items, but I think this should probably be interactive: true, since the fallen stag is likely to be a useful item and is not immediately edible. I believe that interactive: false is primarily intended for Pac Man™ style legacy food-type items.
See #239, #238 and #235
This PR defines a new transition that requires at least two players to be activated. It changes the message displayed to the user to mention whether the transition is currently available, and if it isn't it shows how many more players are needed.
The transition that tests rely on has been included in test code, so that it doesn't need to live in the actual game config.
A transition has been added to turn consume a stag and turn it into a fallen stag (I used a leather purse emoji since I could not find anything more fitting). It's not currently working (I probably introduced a bug), but I'll probably need to work on it a bit more anyway.
requirements.txthas been updated to not include dallinger, andconstraints.txthas been added to support development and deployment using docker.