Make some uniforms global #1317
Conversation
VReaperV
added
T-Improvement
VReaperV
force-pushed
the
material-uniform-global
branch
from
653601a
to
9b943f1
Compare
src/engine/renderer/gl_shader.h
Outdated
| @@ -2497,7 +2497,7 @@ class u_EnvironmentMap0 : | |||
| GLUniformSamplerCube { | |||
| public: | |||
| u_EnvironmentMap0( GLShader* shader ) : | |||
| GLUniformSamplerCube( shader, "u_EnvironmentMap0" ) { | |||
| GLUniformSamplerCube( shader, "u_EnvironmentMap0", true ) { | |||
There was a problem hiding this comment.
I imagine this should be dependent on the surface's position? Currently it is determined from the viewing position but I assume that's just because the old reflective specular code was half unfinished and written while drunk.
There was a problem hiding this comment.
It should be, yeah. I was just going off of whatever code we already had.
There was a problem hiding this comment.
To be more specific, binding cubemaps based on where the surface is will also give bad results, especially if the surface is large. Ideally we'd further divide the frustum (further from the current tiled implementation) into clusters and assign a cubemap to each cluster.
There was a problem hiding this comment.
Actually, this would pretty much require changing from tiled renderer to clustered, because I plan to merge stages with the same data in the buffer, which means that they will point to the wrong cubemaps for most surfaces (right now having separate data for each stage in the material buffer makes it take up about ~10x the space on average and decreases performance).
VReaperV
force-pushed
the
material-uniform-global
branch
from
9b943f1
to
c28370b
Compare
VReaperV
force-pushed
the
material-uniform-global
branch
4 times, most recently
from
32a79ec
to
3c3bed8
Compare
|
Rebased/ready for review again. |
VReaperV
force-pushed
the
material-uniform-global
branch
from
3c3bed8
to
dd0e92e
Compare
VReaperV
force-pushed
the
material-uniform-global
branch
from
dd0e92e
to
66d26f7
Compare
Don't put data that doesn't change into the material buffer.