Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][chunjun-connectors] jdbc's properties not work where jdbc's reader has set properties #1874

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[Bug][chunjun-connectors] jdbc's properties not work where jdbc's reader has set properties #1874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f95feb6
[hotfix-1856] [chunjun-core] Fix the problem that oss's secret shoul…
AliceXiaoLu Dec 14, 2023
5e9e4a1
Merge branch 'DTStack:master' into master
AliceXiaoLu Dec 21, 2023
58ec5f2
Merge branch 'DTStack:master' into master
AliceXiaoLu Feb 2, 2024
01f4def
[Bug][chunjun-connectors] jdbc's properties not work where jdbc's rea…
AliceXiaoLu Feb 18, 2024
f862298
Merge branch 'master' into master
zoudaokoulife Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-jdbc-base/src/main/java/com/dtstack/chunjun/connector/jdbc/source/JdbcSourceFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public JdbcSourceFactory(
if (StringUtils.isBlank(jdbcConfig.getIncreColumn())) jdbcConfig.setPolling(false);
jdbcConfig.setColumn(syncConfig.getReader().getFieldList());

Properties properties = syncConfig.getWriter().getProperties("properties", null);
Properties properties = syncConfig.getReader().getProperties("properties", null);
jdbcConfig.setProperties(properties);

setDefaultSplitStrategy(jdbcConfig);
Expand Down
2 changes: 1 addition & 1 deletion chunjun-core/src/test/java/com/dtstack/chunjun/config/BaseFileConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public void toStringShouldReturnAStringWithAllTheFields() {
baseFileConf.setNextCheckRows(5000L);

String expected =
"BaseFileConfig(fromLine=1, path=path, fileName=fileName, writeMode=writeMode, compress=compress, encoding=UTF-8, maxFileSize=1024, nextCheckRows=5000, suffix=null)";
"BaseFileConfig(fromLine=1, path=path, fileName=fileName, writeMode=writeMode, compress=compress, encoding=UTF-8, maxFileSize=1024, nextCheckRows=5000, suffix=null, jobIdentifier=)";

assertEquals(expected, baseFileConf.toString());
}
Expand Down
Loading