Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][chunjun-connectors] jdbc's properties not work where jdbc's reader has set properties #1874

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AliceXiaoLu
Copy link
Contributor

@AliceXiaoLu AliceXiaoLu commented Feb 18, 2024

Purpose of this pull request

Which issue you fix

Fixes # (issue).

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@AliceXiaoLu
Copy link
Contributor Author

@zoudaokoulife @libailin Please help to review it

@zoudaokoulife
Copy link
Contributor

@AliceXiaoLu 当前提交中包含其他的commit ,merge rebase 失败,请基于mater 分支重新修复提交一个pr.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants