Home
Welcome to the DECD-Design-System wiki!
React Testing Library documentation
ESDC / IT Accessibility Office Resources
Insight on developing accessible libraries
Comparison between Axes an other web browser tools
Screen Reader Tools for testing different browsers
Helpful Commands for Screen Reader Testing
Based on "How to Do Code Reviews Like a Human" by Michael Lynch
- Give code examples - leave a code snippet as a comment or create a branch off of their feature branch
- Avoid "you" - critique the code not the person, use language like "we", "should be", "could be", "how about"
- Avoid commands - use language that frames feedback as a request and starts a conversation or discussion like "can we?", "could this be?", there's no one right way to write code
- Give context - provide background or supporting knowledge when possible
- Give praise - recognize good work
- Limit feedback on repeated patterns - if the same error occurs more then once, point it out in one or two spots and ask the author to fix the pattern
- Respect the scope - if the changelist doesn't touch the line, it's out of scope unless the changelist affects surrounding code