Fix render_mode when loading VecNormalize #1671
Conversation
| # Reformat | ||
| "black", | ||
| "black>=23.9.1,<24", |
There was a problem hiding this comment.
Btw black~=23.9 should do the same here
There was a problem hiding this comment.
yes it is, I do find >=23.9.1,<24 more explicit though (the thing is ~= is not consistent among package managers/languages... :/ see https://jubianchi.github.io/semver-check/#/~23.9/23.10 for instance).
There was a problem hiding this comment.
Oh I did not know this! Is this also the case in the python world?
There was a problem hiding this comment.
so far, I think (and hope) it is fine (I'm mostly sticking to pip/mamba so I cannot say for the rest)
| @@ -38,7 +38,7 @@ pip install -e .[docs,tests,extra] | |||
|
|
|||
| ## Codestyle | |||
|
|
|||
| We use [black codestyle](https://github.com/psf/black) (max line length of 127 characters) together with [isort](https://github.com/timothycrosley/isort) to sort the imports. | |||
| We use [black codestyle](https://github.com/psf/black) (max line length of 127 characters) together with [ruff](https://github.com/astral-sh/ruff) (isort rules) to sort the imports. | |||
There was a problem hiding this comment.
Looking forward to check out ruff :-)
There was a problem hiding this comment.
ruff is already used as a replacement for flake8 and it's pretty fast =)
Description
See DLR-RM/rl-baselines3-zoo#399
I've also switched to ruff in place of isort (everything is faster now, for the same result and less dependencies =)).
Motivation and Context
Types of changes
Checklist
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)Note: You can run most of the checks using
make commit-checks.Note: we are using a maximum length of 127 characters per line