-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gym dependency #403
Conversation
7160eb2
to
186b4a8
Compare
Note: on this branch (maybe on master as well) I still have the issue, that I can't push models that use a VecNormalizeWrapper to the hub. Somehow the wrapper sets the To reproduce: python -m rl_zoo3.train --algo ppo --env MountainCarContinuous-v0 -f reproduce_bug
python -m rl_zoo3.push_to_hub --algo ppo --env MountainCarContinuous-v0 -f reproduce_bug --organization <YOUR ORGA> gives me the followign output:
|
Right now the pipeline fails because mypy does not like that we assign
|
Should be fixed with DLR-RM/stable-baselines3#1671 (I will give it a try soon)
let me check, might be due to an update to mypy or other packages. |
I cannot reproduce with SB3 master version, so I guess it is fixed =) |
I also have no idea for those questions, but I fixed mypy check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks =)
Description
Removes the dependency to
gym
in favor ofgymnasium
.Motivation and Context
Fixes #398
Types of changes
Checklist:
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)Note: we are using a maximum length of 127 characters per line